All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH for 4.5] libxl: Tell qemu to use raw format when using a tapdisk
Date: Tue, 16 Dec 2014 17:19:25 +0000	[thread overview]
Message-ID: <1418750365.20265.6.camel@citrix.com> (raw)
In-Reply-To: <CAFLBxZbOyDq63c8groyCSE5etDV1K+5htTwoNqqhRj2CL2fmqw@mail.gmail.com>

On Mon, 2014-12-15 at 16:47 +0000, George Dunlap wrote:
> On Wed, Dec 10, 2014 at 4:30 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> > On Tue, Dec 09, 2014 at 02:48:21PM +0000, Ian Campbell wrote:
> >> On Tue, 2014-12-09 at 14:04 +0000, George Dunlap wrote:
> >> > At the moment libxl unconditinally passes the underlying file format
> >> > to qemu in the device string.  However, when tapdisk is in use,
> >> > tapdisk handles the underlying format and presents qemu with
> >> > effectively a raw disk.  When qemu looks at the tapdisk block device
> >> > and doesn't find the image format it was looking for, it will fail.
> >> >
> >> > This effectively means that tapdisk cannot be used with HVM domains at
> >> > the moment except for raw files.
> >> >
> >> > Instead, if we're using a tapdisk backend, tell qemu to use a raw file
> >> > format.
> >> >
> >> > Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> >>
> >> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> This doesn't seem to have been applied yet.

Now applied, nuking the extra blank line which way noticed on the way.

Ian.

  reply	other threads:[~2014-12-16 17:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 14:04 [PATCH for 4.5] libxl: Tell qemu to use raw format when using a tapdisk George Dunlap
2014-12-09 14:32 ` Wei Liu
2014-12-09 14:34   ` George Dunlap
2014-12-09 14:48 ` Ian Campbell
2014-12-10 16:30   ` Konrad Rzeszutek Wilk
2014-12-15 16:47     ` George Dunlap
2014-12-16 17:19       ` Ian Campbell [this message]
2014-12-15 15:29 ` Wei Liu
     [not found] ` <20141215154710.GC8049@zion.uk.xensource.com>
2014-12-15 16:00   ` Processed: " xen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418750365.20265.6.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=ian.jackson@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.