From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.5] libxl: Tell qemu to use raw format when using a tapdisk Date: Tue, 16 Dec 2014 17:19:25 +0000 Message-ID: <1418750365.20265.6.camel@citrix.com> References: <1418133859-27763-1-git-send-email-george.dunlap@eu.citrix.com> <1418136501.14361.83.camel@citrix.com> <20141210163046.GF4268@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Ian Jackson , "xen-devel@lists.xen.org" , Wei Liu List-Id: xen-devel@lists.xenproject.org On Mon, 2014-12-15 at 16:47 +0000, George Dunlap wrote: > On Wed, Dec 10, 2014 at 4:30 PM, Konrad Rzeszutek Wilk > wrote: > > On Tue, Dec 09, 2014 at 02:48:21PM +0000, Ian Campbell wrote: > >> On Tue, 2014-12-09 at 14:04 +0000, George Dunlap wrote: > >> > At the moment libxl unconditinally passes the underlying file format > >> > to qemu in the device string. However, when tapdisk is in use, > >> > tapdisk handles the underlying format and presents qemu with > >> > effectively a raw disk. When qemu looks at the tapdisk block device > >> > and doesn't find the image format it was looking for, it will fail. > >> > > >> > This effectively means that tapdisk cannot be used with HVM domains at > >> > the moment except for raw files. > >> > > >> > Instead, if we're using a tapdisk backend, tell qemu to use a raw file > >> > format. > >> > > >> > Signed-off-by: George Dunlap > >> > >> Acked-by: Ian Campbell > > > > Release-Acked-by: Konrad Rzeszutek Wilk > > This doesn't seem to have been applied yet. Now applied, nuking the extra blank line which way noticed on the way. Ian.