From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: "John Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Felix Fietkau" <nbd@openwrt.org>,
"Thomas Hühn" <thomas@net.t-labs.tu-berlin.de>,
adrian@freebsd.org, haim.dreyfuss@intel.com
Subject: Re: [PATCHv2] mac80211: enable TPC through mac80211 stack
Date: Wed, 17 Dec 2014 11:51:00 +0100 [thread overview]
Message-ID: <1418813460.2135.9.camel@sipsolutions.net> (raw)
In-Reply-To: <CAA2SeN+71_ZR_H-Mkb5+PLwVe6dhCoknh8puWUjFXf73Ab1MnA@mail.gmail.com> (sfid-20141215_144037_670662_0791986A)
On Mon, 2014-12-15 at 14:40 +0100, Lorenzo Bianconi wrote:
> In pending driver (ath9k) patches TPC related info in hw conf and
> bss_conf are not used for the same purpose. The first one is used to
> configure HW TPC registers, since TPC should be enabled in hw if there
> is at least one interface where TPC has been configured, whereas the
> latter it use to figure out if the transmitted frame belongs to a vif
> where TPC has been previously enabled. If I do not set TPC info in hw
> conf I have to loop over all vif every time TPC configuration is
> applied from mac80211, since ath9k uses just hw conf structure to set
> TX power info. Maybe that solution is a little bit tricky. What do you
> think? Sorry if in previous emails I was not so clear :)
But you also didn't really implement that logic in mac80211?
IMHO this is a driver quirk that the driver should worry about.
johannes
prev parent reply other threads:[~2014-12-17 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 10:30 [PATCHv2] mac80211: enable TPC through mac80211 stack Lorenzo Bianconi
2014-12-12 12:26 ` Johannes Berg
2014-12-12 14:16 ` Lorenzo Bianconi
2014-12-15 12:29 ` Johannes Berg
2014-12-15 13:40 ` Lorenzo Bianconi
2014-12-17 10:51 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418813460.2135.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adrian@freebsd.org \
--cc=haim.dreyfuss@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@openwrt.org \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.