From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Praveen Madhavan <praveenm@chelsio.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: Using common code for csiostor.
Date: Wed, 17 Dec 2014 08:10:15 -0800 [thread overview]
Message-ID: <1418832615.3052.36.camel@HansenPartnership.com> (raw)
In-Reply-To: <24C222ADD7729F4FB5113B41FF0028A1BC8C12@nice.asicdesigners.com>
On Wed, 2014-12-17 at 15:51 +0000, Praveen Madhavan wrote:
> Hi Christoph,
> csiostor is chelsio full offload FCoE physical function driver. I
> would like to reuse common hardware interface functions defined in
> t4_hw.c of chelsio networking driver(cxgb4). Below is makefile change
> that creates softlink to t4_hw.c and builds the same. Is this change
> is acceptable? Please suggest if there is any better way of doing
> this.
The usual way to do this is to make the common hardware function a base
module and make all drivers that use it depend on it. Like iwldvm ->
iwlwifi -> mac80211 etc.
We really wouldn't want to do the link and build because that will
create two identical binary copies of the interface (one in SCSI and one
in net) which is a waste of text space.
James
next prev parent reply other threads:[~2014-12-17 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 15:51 Using common code for csiostor Praveen Madhavan
2014-12-17 16:10 ` James Bottomley [this message]
2014-12-30 12:23 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418832615.3052.36.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=praveenm@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.