From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Bjorn <bjorn@sonymobile.com>
Cc: Bryan Wu <cooloney@gmail.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Richard Purdie <rpurdie@rpsys.net>,
Grant Likely <grant.likely@linaro.org>,
"Cavin, Courtney" <Courtney.Cavin@sonymobile.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 2/2] leds: add Qualcomm PM8941 WLED driver
Date: Fri, 19 Dec 2014 10:15:29 +0200 [thread overview]
Message-ID: <1418976929.27549.5.camel@mm-sol.com> (raw)
In-Reply-To: <20141218234352.GE19036@sonymobile.com>
On Thu, 2014-12-18 at 15:43 -0800, Bjorn wrote:
> On Tue 16 Dec 16:54 PST 2014, Bryan Wu wrote:
>
> > On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson
>
> [..]
>
> > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>
> [..]
>
> > > +config LEDS_PM8941_WLED
> > > + tristate "LED support for the Qualcomm PM8941 WLED block"
> > > + depends on LEDS_CLASS
> > > + depends on REGMAP
> > Here should be "select REGMAP"
> >
>
> Thanks
> > >
If not mistaken the correct way was:
depends on SPMI
select REGMAP_SPMI
or
depends on MFD_SPMI_PMIC
Regards,
Ivan
https://patchwork.kernel.org/patch/4566591/
next prev parent reply other threads:[~2014-12-19 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 0:22 [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block Bjorn Andersson
2014-12-09 0:22 ` Bjorn Andersson
2014-12-09 0:22 ` [PATCH 2/2] leds: add Qualcomm PM8941 WLED driver Bjorn Andersson
2014-12-09 0:22 ` Bjorn Andersson
2014-12-17 0:54 ` Bryan Wu
2014-12-18 23:43 ` Bjorn
2014-12-19 8:15 ` Ivan T. Ivanov [this message]
2014-12-17 1:15 ` Stephen Boyd
2014-12-18 23:57 ` Bjorn
2014-12-10 1:19 ` [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block Bryan Wu
2014-12-17 0:54 ` Bryan Wu
2014-12-17 1:15 ` Stephen Boyd
2014-12-18 23:36 ` Bjorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418976929.27549.5.camel@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=Courtney.Cavin@sonymobile.com \
--cc=bjorn@sonymobile.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.