From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [RFC V9 3/4] domain snapshot design: xl Date: Fri, 19 Dec 2014 10:27:36 +0000 Message-ID: <1418984856.20028.17.camel@citrix.com> References: <1418711577-15449-1-git-send-email-cyliu@suse.com> <1418711577-15449-4-git-send-email-cyliu@suse.com> <1418915759.11882.91.camel@citrix.com> <54943E5F0200006600086A70@soto.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54943E5F0200006600086A70@soto.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chun Yan Liu Cc: ian.jackson@eu.citrix.com, Jim Fehlig , wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2014-12-19 at 00:03 -0700, Chun Yan Liu wrote: > '--name' meant to give a meaningful name (like: newinstall. Used as the > memory snapshot name and disk snapshot name). Where is this name stored and when and where would it be presented to the user? > That's good. Then we need to add some description to tell users about > the auto-generated domain snapshot name, disk snapshot name, > memory state file and external disk snapshot files, etc. We will need user docs and manpage updates, yes. > > > #e.g. to specify exernal disk snapshot, like this: > > > #disks=['/tmp/hda_snapshot.qcow2,qcow2,hda', > > > '/tmp/hdb_snapshot.qcow2,qcow2,hdb',] > > > > > > #e.g. to specify internal disk snapshot, like this: > > > disks=[',,hda',',,hdb',] > > > > Ideally one or the other of these behaviours would be possible without > > needing to be quite so explicit. > > OK, I'll delete one. I don't object to having this more capable syntax as an option, so the user can override things if they wish, all I was suggesting is that the default ought to be something useful so the user doesn't need to say anything if they just want the toolstack to "do something sensible". Ian.