From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Kai Kang <kai.kang@windriver.com>, Koen Kooi <koen.kooi@linaro.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 08/19] libpng 1.6.13: fix build for aarch64
Date: Mon, 22 Dec 2014 09:41:29 +0000 [thread overview]
Message-ID: <1419241289.13316.67.camel@linuxfoundation.org> (raw)
In-Reply-To: <38c83309734f903e97c3b8e51b0d6c501d1f2ded.1418885581.git.kai.kang@windriver.com>
On Thu, 2014-12-18 at 16:51 +0800, Kai Kang wrote:
> From: Koen Kooi <koen.kooi@linaro.org>
>
> The configure override was too restrictive, it needed both 'arm' and
> 'neon' to trigger, which breaks on aarch64. Since TUNE_FEATURES is the
> only qualifier that matters, drop the 'arm' override.
>
> Buildtested for 'genericarmv8' and 'qemux86' machines.
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
> meta/recipes-multimedia/libpng/libpng_1.6.13.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/libpng/libpng_1.6.13.bb b/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
> index 0c6fd1f..8798a96 100644
> --- a/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
> +++ b/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
> @@ -19,7 +19,7 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config"
> inherit autotools binconfig-disabled pkgconfig
>
> # Work around missing symbols
> -EXTRA_OECONF_append_arm = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
> +EXTRA_OECONF_append = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
>
> PACKAGES =+ "${PN}-tools"
>
I tried a test build of this series and see:
https://autobuilder.yoctoproject.org/main/builders/nightly-arm/builds/136/steps/BuildImages_1/logs/stdio
in the output. Could someone look into that please? I'm guessing its
related to this patch although I haven't bisected exactly.
Cheers,
Richard
next prev parent reply other threads:[~2014-12-22 9:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 8:50 [PATCH 00/19] V3: Add machine qemuarm64 Kai Kang
2014-12-18 8:50 ` [PATCH 01/19] linux-yocto: depend on libgcc for aarch64 Kai Kang
2015-01-01 1:31 ` Khem Raj
2014-12-18 8:50 ` [PATCH 02/19] Add machine qemuarm64 Kai Kang
2014-12-18 8:50 ` [PATCH 03/19] siteinfo: account for 32 and 64 bit arm Kai Kang
2014-12-18 8:51 ` [PATCH 04/19] libc-package.bbclass: add aarch64 target to locale_arch_options Kai Kang
2014-12-18 8:51 ` [PATCH 05/19] glibc-locale.inc: add aarch64 to BINARY_LOCALE_ARCHES Kai Kang
2014-12-18 8:51 ` [PATCH 06/19] libatomics-ops: add aarch64 target iniitial support Kai Kang
2014-12-18 8:51 ` [PATCH 07/19] qt4: add aarch64 support Kai Kang
2014-12-18 8:51 ` [PATCH 08/19] libpng 1.6.13: fix build for aarch64 Kai Kang
2014-12-22 9:41 ` Richard Purdie [this message]
2014-12-22 10:57 ` Richard Purdie
2014-12-18 8:51 ` [PATCH 09/19] sysprof: disable " Kai Kang
2014-12-18 8:51 ` [PATCH 10/19] lttng: recognize aarch64 Kai Kang
2014-12-18 8:51 ` [PATCH 11/19] guile: allow compilation for aarch64 Kai Kang
2015-01-01 1:25 ` Khem Raj
2014-12-18 8:51 ` [PATCH 12/19] libunwind: add aarch64 support Kai Kang
2014-12-18 8:51 ` [PATCH 13/19] runqemu: add qemuarm64 support Kai Kang
2015-01-01 1:27 ` Khem Raj
2015-01-04 2:38 ` Kang Kai
2014-12-18 8:51 ` [PATCH 14/19] kexec-tools: add aarch64 support Kai Kang
2014-12-18 8:51 ` [PATCH 15/19] packagegroup-core-tools-profile: remove sysprof for aarch64 Kai Kang
2014-12-18 8:51 ` [PATCH 16/19] gcc: Disable aarch64 multilib options Kai Kang
2014-12-18 8:51 ` [PATCH 17/19] glibc-package: aarch64 enable symlink for ABI compliance Kai Kang
2014-12-18 8:51 ` [PATCH 18/19] aarch-arm64: Update tune files Kai Kang
2015-01-01 1:54 ` Khem Raj
2014-12-18 8:51 ` [PATCH 19/19] linux-yocto: Fixup linux-yocto for aarch64 Kai Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419241289.13316.67.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=kai.kang@windriver.com \
--cc=koen.kooi@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.