From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org,
Dongsheng Wang <dongsheng.wang@freescale.com>,
anton@samba.org
Subject: Re: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
Date: Tue, 23 Dec 2014 10:55:53 +0100 [thread overview]
Message-ID: <1419328553.27103.66.camel@kernel.crashing.org> (raw)
In-Reply-To: <1419296441.30550.3.camel@ellerman.id.au>
On Tue, 2014-12-23 at 12:00 +1100, Michael Ellerman wrote:
> On Mon, 2014-12-22 at 14:38 +0800, Dongsheng Wang wrote:
> > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> >
> > Kernel cannot bring up Non-boot cpus always get "Processor xx is stuck".
> > this issue bring by http://patchwork.ozlabs.org/patch/418912/ (powerpc:
> > Secondary CPUs must set cpu_callin_map after setting active and online)
> > We need to take timebase after bootup cpu give the timebase firstly.
> >
> > When start_secondary, non-boot cpus set cpu_callin_map for boot cpu
> > after that boot cpu will give the timebase for non-boot cpu. Otherwise
> > non-boot cpus will fall in dead loop to waiting bootup cpu to give
> > imebase.
>
> Right.
>
> However, doesn't this introduce the possibility that the secondary cpu is up
> and marked online but has an unsynchronised clock?
As long as it doesn't execute anything (and at that point it shouldn't
have interrupts enabled) it should be ok. The TB cannot be observed
outside of that CPU.
Cheers,
Ben.
next prev parent reply other threads:[~2014-12-23 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 6:38 [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up Dongsheng Wang
2014-12-23 1:00 ` Michael Ellerman
2014-12-23 2:41 ` Dongsheng.Wang
2014-12-23 5:45 ` Michael Ellerman
2014-12-23 6:53 ` Dongsheng.Wang
2014-12-23 7:55 ` Dongsheng.Wang
2014-12-23 9:55 ` Benjamin Herrenschmidt [this message]
2014-12-26 12:09 ` Aaro Koskinen
2014-12-29 9:01 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419328553.27103.66.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=dongsheng.wang@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.