* [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
@ 2014-12-22 6:38 Dongsheng Wang
2014-12-23 1:00 ` Michael Ellerman
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Dongsheng Wang @ 2014-12-22 6:38 UTC (permalink / raw)
To: benh, scottwood, anton; +Cc: linuxppc-dev, Wang Dongsheng
From: Wang Dongsheng <dongsheng.wang@freescale.com>
Kernel cannot bring up Non-boot cpus always get "Processor xx is stuck".
this issue bring by http://patchwork.ozlabs.org/patch/418912/ (powerpc:
Secondary CPUs must set cpu_callin_map after setting active and online)
We need to take timebase after bootup cpu give the timebase firstly.
When start_secondary, non-boot cpus set cpu_callin_map for boot cpu
after that boot cpu will give the timebase for non-boot cpu. Otherwise
non-boot cpus will fall in dead loop to waiting bootup cpu to give
imebase.
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 8ec017c..9e29836 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -703,10 +703,6 @@ void start_secondary(void *unused)
if (smp_ops->setup_cpu)
smp_ops->setup_cpu(cpu);
- if (smp_ops->take_timebase)
- smp_ops->take_timebase();
-
- secondary_cpu_time_init();
#ifdef CONFIG_PPC64
if (system_state == SYSTEM_RUNNING)
@@ -746,6 +742,16 @@ void start_secondary(void *unused)
smp_wmb();
cpu_callin_map[cpu] = 1;
+ /*
+ * We need to take timebase after bootup cpu give the timebase.
+ * Base on cpu_callin_map move to here, so we also need move
+ * take_timebase. Because bootup cpu waiting for cpu_callin_map
+ * be set after that give_timebase can be executed.
+ */
+ if (smp_ops->take_timebase)
+ smp_ops->take_timebase();
+ secondary_cpu_time_init();
+
local_irq_enable();
cpu_startup_entry(CPUHP_ONLINE);
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-22 6:38 [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up Dongsheng Wang
@ 2014-12-23 1:00 ` Michael Ellerman
2014-12-23 2:41 ` Dongsheng.Wang
2014-12-23 9:55 ` Benjamin Herrenschmidt
2014-12-26 12:09 ` Aaro Koskinen
2014-12-29 9:01 ` Michael Ellerman
2 siblings, 2 replies; 9+ messages in thread
From: Michael Ellerman @ 2014-12-23 1:00 UTC (permalink / raw)
To: Dongsheng Wang; +Cc: scottwood, linuxppc-dev, anton
On Mon, 2014-12-22 at 14:38 +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> Kernel cannot bring up Non-boot cpus always get "Processor xx is stuck".
> this issue bring by http://patchwork.ozlabs.org/patch/418912/ (powerpc:
> Secondary CPUs must set cpu_callin_map after setting active and online)
> We need to take timebase after bootup cpu give the timebase firstly.
>
> When start_secondary, non-boot cpus set cpu_callin_map for boot cpu
> after that boot cpu will give the timebase for non-boot cpu. Otherwise
> non-boot cpus will fall in dead loop to waiting bootup cpu to give
> imebase.
Right.
However, doesn't this introduce the possibility that the secondary cpu is up
and marked online but has an unsynchronised clock?
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-23 1:00 ` Michael Ellerman
@ 2014-12-23 2:41 ` Dongsheng.Wang
2014-12-23 5:45 ` Michael Ellerman
2014-12-23 9:55 ` Benjamin Herrenschmidt
1 sibling, 1 reply; 9+ messages in thread
From: Dongsheng.Wang @ 2014-12-23 2:41 UTC (permalink / raw)
To: Michael Ellerman
Cc: Scott Wood, linuxppc-dev@lists.ozlabs.org, anton@samba.org
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTWljaGFlbCBFbGxlcm1h
biBbbWFpbHRvOm1wZUBlbGxlcm1hbi5pZC5hdV0NCj4gU2VudDogVHVlc2RheSwgRGVjZW1iZXIg
MjMsIDIwMTQgOTowMSBBTQ0KPiBUbzogV2FuZyBEb25nc2hlbmctQjQwNTM0DQo+IENjOiBiZW5o
QGtlcm5lbC5jcmFzaGluZy5vcmc7IFdvb2QgU2NvdHQtQjA3NDIxOyBhbnRvbkBzYW1iYS5vcmc7
IGxpbnV4cHBjLQ0KPiBkZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENI
XSBwb3dlcnBjL3NtcDogRml4IE5vbi1ib290IGNwdXMgY2Fubm90IGJlIGJyaW5nIHVwLg0KPiAN
Cj4gT24gTW9uLCAyMDE0LTEyLTIyIGF0IDE0OjM4ICswODAwLCBEb25nc2hlbmcgV2FuZyB3cm90
ZToNCj4gPiBGcm9tOiBXYW5nIERvbmdzaGVuZyA8ZG9uZ3NoZW5nLndhbmdAZnJlZXNjYWxlLmNv
bT4NCj4gPg0KPiA+IEtlcm5lbCBjYW5ub3QgYnJpbmcgdXAgTm9uLWJvb3QgY3B1cyBhbHdheXMg
Z2V0ICJQcm9jZXNzb3IgeHggaXMgc3R1Y2siLg0KPiA+IHRoaXMgaXNzdWUgYnJpbmcgYnkgaHR0
cDovL3BhdGNod29yay5vemxhYnMub3JnL3BhdGNoLzQxODkxMi8gKHBvd2VycGM6DQo+ID4gU2Vj
b25kYXJ5IENQVXMgbXVzdCBzZXQgY3B1X2NhbGxpbl9tYXAgYWZ0ZXIgc2V0dGluZyBhY3RpdmUg
YW5kDQo+ID4gb25saW5lKSBXZSBuZWVkIHRvIHRha2UgdGltZWJhc2UgYWZ0ZXIgYm9vdHVwIGNw
dSBnaXZlIHRoZSB0aW1lYmFzZSBmaXJzdGx5Lg0KPiA+DQo+ID4gV2hlbiBzdGFydF9zZWNvbmRh
cnksIG5vbi1ib290IGNwdXMgc2V0IGNwdV9jYWxsaW5fbWFwIGZvciBib290IGNwdQ0KPiA+IGFm
dGVyIHRoYXQgYm9vdCBjcHUgd2lsbCBnaXZlIHRoZSB0aW1lYmFzZSBmb3Igbm9uLWJvb3QgY3B1
LiBPdGhlcndpc2UNCj4gPiBub24tYm9vdCBjcHVzIHdpbGwgZmFsbCBpbiBkZWFkIGxvb3AgdG8g
d2FpdGluZyBib290dXAgY3B1IHRvIGdpdmUNCj4gPiBpbWViYXNlLg0KPiANCj4gUmlnaHQuDQo+
IA0KPiBIb3dldmVyLCBkb2Vzbid0IHRoaXMgaW50cm9kdWNlIHRoZSBwb3NzaWJpbGl0eSB0aGF0
IHRoZSBzZWNvbmRhcnkgY3B1IGlzIHVwIGFuZA0KPiBtYXJrZWQgb25saW5lIGJ1dCBoYXMgYW4g
dW5zeW5jaHJvbmlzZWQgY2xvY2s/DQo+IA0KWWVzLCByaWdodC4gQnV0IEZyZWVzY2FsZSBwbGF0
Zm9ybSBib290LWNwdSB3aWxsIGZyZWV6ZSB0aGUgVEIgdW50aWwgc2Vjb25kYXJ5IGNwdQ0KdGFr
ZSB0aGUgdGltZSBiYXNlLCBzbyB0aGUgY2xvY2sgaXMgc3luY2hyb25pemVkLg0KDQpGb3IgZ2Vu
ZXJpYyBQb3dlclBDIG1heWJlIGhhcyB0aGlzIGlzc3VlLiBTbyBmb3Igc2FmZSBJIHRoaW5rIHdl
IG5lZWQgdG8gc2V0IGNwdSBvbmxpbmUNCmFmdGVyIHN5bmNocm9uaXplZCBjbG9jay4NCg0KSSB3
aWxsIHVwZGF0ZSBteSBwYXRjaCBpZiB5b3UgYWdyZWUgdGhpcyB3YXkuDQorICAgICAgIGlmIChz
bXBfb3BzLT50YWtlX3RpbWViYXNlKQ0KKyAgICAgICAgICAgICAgIHNtcF9vcHMtPnRha2VfdGlt
ZWJhc2UoKTsNCisgICAgICAgc2Vjb25kYXJ5X2NwdV90aW1lX2luaXQoKTsNCisNCk1vdmUgc2V0
X2NwdV9vbmxpbmUgdG8gaGVyZS4NCisgICAgICAgc2V0X2NwdV9vbmxpbmUoY3B1LCB0cnVlKTsN
Cg0KUmVnYXJkcywNCi1Eb25nc2hlbmcNCg==
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-23 2:41 ` Dongsheng.Wang
@ 2014-12-23 5:45 ` Michael Ellerman
2014-12-23 6:53 ` Dongsheng.Wang
2014-12-23 7:55 ` Dongsheng.Wang
0 siblings, 2 replies; 9+ messages in thread
From: Michael Ellerman @ 2014-12-23 5:45 UTC (permalink / raw)
To: Dongsheng.Wang@freescale.com
Cc: Scott Wood, linuxppc-dev@lists.ozlabs.org, anton@samba.org
On Tue, 2014-12-23 at 02:41 +0000, Dongsheng.Wang@freescale.com wrote:
> > -----Original Message-----
> > From: Michael Ellerman [mailto:mpe@ellerman.id.au]
> > Sent: Tuesday, December 23, 2014 9:01 AM
> > To: Wang Dongsheng-B40534
> > Cc: benh@kernel.crashing.org; Wood Scott-B07421; anton@samba.org; linuxppc-
> > dev@lists.ozlabs.org
> > Subject: Re: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
> >
> > On Mon, 2014-12-22 at 14:38 +0800, Dongsheng Wang wrote:
> > > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> > >
> > > Kernel cannot bring up Non-boot cpus always get "Processor xx is stuck".
> > > this issue bring by http://patchwork.ozlabs.org/patch/418912/ (powerpc:
> > > Secondary CPUs must set cpu_callin_map after setting active and
> > > online) We need to take timebase after bootup cpu give the timebase firstly.
> > >
> > > When start_secondary, non-boot cpus set cpu_callin_map for boot cpu
> > > after that boot cpu will give the timebase for non-boot cpu. Otherwise
> > > non-boot cpus will fall in dead loop to waiting bootup cpu to give
> > > imebase.
> >
> > Right.
> >
> > However, doesn't this introduce the possibility that the secondary cpu is up and
> > marked online but has an unsynchronised clock?
> Yes, right. But Freescale platform boot-cpu will freeze the TB until secondary cpu
> take the time base, so the clock is synchronized.
It does the freeze in give_timebase() doesn't it?
So there's still a window there where the secondary is up & online but hasn't
had it's timebase synchronised, and the primary hasn't frozen the timebase yet.
So that makes me nervous.
> For generic PowerPC maybe has this issue. So for safe I think we need to set cpu online
> after synchronized clock.
>
> I will update my patch if you agree this way.
> + if (smp_ops->take_timebase)
> + smp_ops->take_timebase();
> + secondary_cpu_time_init();
> +
> Move set_cpu_online to here.
> + set_cpu_online(cpu, true);
But that reverses the effect of the original patch, which was that we have to
set online *before* we set the callin map.
Looking harder at Anton's patch I'm not sure it's right anyway.
The issue he was trying to fix was that the cpu was online but not active,
which confused the scheduler.
I think Anton missed that we have a loop that waits for online at the bottom of
__cpu_up():
/* Wait until cpu puts itself in the online map */
while (!cpu_online(cpu))
cpu_relax();
He must have seen a case where that popped due to the cpu being online, but the
cpu wasn't yet active.
His patch fixed the problem by ensuring the previous loop that waits for
cpu_callin_map doesn't finish until active & online are set, making the while
loop above a nop.
So I think we should probably revert Anton's patch and instead change that
while loop to:
/* Wait until cpu is online AND active */
while (!cpu_online(cpu) || !cpu_active(cpu))
cpu_relax();
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-23 5:45 ` Michael Ellerman
@ 2014-12-23 6:53 ` Dongsheng.Wang
2014-12-23 7:55 ` Dongsheng.Wang
1 sibling, 0 replies; 9+ messages in thread
From: Dongsheng.Wang @ 2014-12-23 6:53 UTC (permalink / raw)
To: Michael Ellerman
Cc: Scott Wood, linuxppc-dev@lists.ozlabs.org, anton@samba.org
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTWljaGFlbCBFbGxlcm1h
biBbbWFpbHRvOm1wZUBlbGxlcm1hbi5pZC5hdV0NCj4gU2VudDogVHVlc2RheSwgRGVjZW1iZXIg
MjMsIDIwMTQgMTo0NiBQTQ0KPiBUbzogV2FuZyBEb25nc2hlbmctQjQwNTM0DQo+IENjOiBiZW5o
QGtlcm5lbC5jcmFzaGluZy5vcmc7IFdvb2QgU2NvdHQtQjA3NDIxOyBhbnRvbkBzYW1iYS5vcmc7
IGxpbnV4cHBjLQ0KPiBkZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENI
XSBwb3dlcnBjL3NtcDogRml4IE5vbi1ib290IGNwdXMgY2Fubm90IGJlIGJyaW5nIHVwLg0KPiAN
Cj4gT24gVHVlLCAyMDE0LTEyLTIzIGF0IDAyOjQxICswMDAwLCBEb25nc2hlbmcuV2FuZ0BmcmVl
c2NhbGUuY29tIHdyb3RlOg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+
IEZyb206IE1pY2hhZWwgRWxsZXJtYW4gW21haWx0bzptcGVAZWxsZXJtYW4uaWQuYXVdDQo+ID4g
PiBTZW50OiBUdWVzZGF5LCBEZWNlbWJlciAyMywgMjAxNCA5OjAxIEFNDQo+ID4gPiBUbzogV2Fu
ZyBEb25nc2hlbmctQjQwNTM0DQo+ID4gPiBDYzogYmVuaEBrZXJuZWwuY3Jhc2hpbmcub3JnOyBX
b29kIFNjb3R0LUIwNzQyMTsgYW50b25Ac2FtYmEub3JnOw0KPiA+ID4gbGludXhwcGMtIGRldkBs
aXN0cy5vemxhYnMub3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBwb3dlcnBjL3NtcDog
Rml4IE5vbi1ib290IGNwdXMgY2Fubm90IGJlIGJyaW5nIHVwLg0KPiA+ID4NCj4gPiA+IE9uIE1v
biwgMjAxNC0xMi0yMiBhdCAxNDozOCArMDgwMCwgRG9uZ3NoZW5nIFdhbmcgd3JvdGU6DQo+ID4g
PiA+IEZyb206IFdhbmcgRG9uZ3NoZW5nIDxkb25nc2hlbmcud2FuZ0BmcmVlc2NhbGUuY29tPg0K
PiA+ID4gPg0KPiA+ID4gPiBLZXJuZWwgY2Fubm90IGJyaW5nIHVwIE5vbi1ib290IGNwdXMgYWx3
YXlzIGdldCAiUHJvY2Vzc29yIHh4IGlzIHN0dWNrIi4NCj4gPiA+ID4gdGhpcyBpc3N1ZSBicmlu
ZyBieSBodHRwOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvNDE4OTEyLyAocG93ZXJwYzoN
Cj4gPiA+ID4gU2Vjb25kYXJ5IENQVXMgbXVzdCBzZXQgY3B1X2NhbGxpbl9tYXAgYWZ0ZXIgc2V0
dGluZyBhY3RpdmUgYW5kDQo+ID4gPiA+IG9ubGluZSkgV2UgbmVlZCB0byB0YWtlIHRpbWViYXNl
IGFmdGVyIGJvb3R1cCBjcHUgZ2l2ZSB0aGUgdGltZWJhc2UNCj4gZmlyc3RseS4NCj4gPiA+ID4N
Cj4gPiA+ID4gV2hlbiBzdGFydF9zZWNvbmRhcnksIG5vbi1ib290IGNwdXMgc2V0IGNwdV9jYWxs
aW5fbWFwIGZvciBib290DQo+ID4gPiA+IGNwdSBhZnRlciB0aGF0IGJvb3QgY3B1IHdpbGwgZ2l2
ZSB0aGUgdGltZWJhc2UgZm9yIG5vbi1ib290IGNwdS4NCj4gPiA+ID4gT3RoZXJ3aXNlIG5vbi1i
b290IGNwdXMgd2lsbCBmYWxsIGluIGRlYWQgbG9vcCB0byB3YWl0aW5nIGJvb3R1cA0KPiA+ID4g
PiBjcHUgdG8gZ2l2ZSBpbWViYXNlLg0KPiA+ID4NCj4gPiA+IFJpZ2h0Lg0KPiA+ID4NCj4gPiA+
IEhvd2V2ZXIsIGRvZXNuJ3QgdGhpcyBpbnRyb2R1Y2UgdGhlIHBvc3NpYmlsaXR5IHRoYXQgdGhl
IHNlY29uZGFyeQ0KPiA+ID4gY3B1IGlzIHVwIGFuZCBtYXJrZWQgb25saW5lIGJ1dCBoYXMgYW4g
dW5zeW5jaHJvbmlzZWQgY2xvY2s/DQo+IA0KPiA+IFllcywgcmlnaHQuIEJ1dCBGcmVlc2NhbGUg
cGxhdGZvcm0gYm9vdC1jcHUgd2lsbCBmcmVlemUgdGhlIFRCIHVudGlsDQo+ID4gc2Vjb25kYXJ5
IGNwdSB0YWtlIHRoZSB0aW1lIGJhc2UsIHNvIHRoZSBjbG9jayBpcyBzeW5jaHJvbml6ZWQuDQo+
IA0KPiBJdCBkb2VzIHRoZSBmcmVlemUgaW4gZ2l2ZV90aW1lYmFzZSgpIGRvZXNuJ3QgaXQ/DQo+
IA0KPiBTbyB0aGVyZSdzIHN0aWxsIGEgd2luZG93IHRoZXJlIHdoZXJlIHRoZSBzZWNvbmRhcnkg
aXMgdXAgJiBvbmxpbmUgYnV0IGhhc24ndA0KPiBoYWQgaXQncyB0aW1lYmFzZSBzeW5jaHJvbmlz
ZWQsIGFuZCB0aGUgcHJpbWFyeSBoYXNuJ3QgZnJvemVuIHRoZSB0aW1lYmFzZSB5ZXQuDQo+IFNv
IHRoYXQgbWFrZXMgbWUgbmVydm91cy4NCj4gDQo+ID4gRm9yIGdlbmVyaWMgUG93ZXJQQyBtYXli
ZSBoYXMgdGhpcyBpc3N1ZS4gU28gZm9yIHNhZmUgSSB0aGluayB3ZSBuZWVkDQo+ID4gdG8gc2V0
IGNwdSBvbmxpbmUgYWZ0ZXIgc3luY2hyb25pemVkIGNsb2NrLg0KPiA+DQo+ID4gSSB3aWxsIHVw
ZGF0ZSBteSBwYXRjaCBpZiB5b3UgYWdyZWUgdGhpcyB3YXkuDQo+ID4gKyAgICAgICBpZiAoc21w
X29wcy0+dGFrZV90aW1lYmFzZSkNCj4gPiArICAgICAgICAgICAgICAgc21wX29wcy0+dGFrZV90
aW1lYmFzZSgpOw0KPiA+ICsgICAgICAgc2Vjb25kYXJ5X2NwdV90aW1lX2luaXQoKTsNCj4gPiAr
DQo+ID4gTW92ZSBzZXRfY3B1X29ubGluZSB0byBoZXJlLg0KPiA+ICsgICAgICAgc2V0X2NwdV9v
bmxpbmUoY3B1LCB0cnVlKTsNCj4gDQo+IEJ1dCB0aGF0IHJldmVyc2VzIHRoZSBlZmZlY3Qgb2Yg
dGhlIG9yaWdpbmFsIHBhdGNoLCB3aGljaCB3YXMgdGhhdCB3ZSBoYXZlIHRvDQo+IHNldCBvbmxp
bmUgKmJlZm9yZSogd2Ugc2V0IHRoZSBjYWxsaW4gbWFwLg0KPiANCj4gDQo+IExvb2tpbmcgaGFy
ZGVyIGF0IEFudG9uJ3MgcGF0Y2ggSSdtIG5vdCBzdXJlIGl0J3MgcmlnaHQgYW55d2F5Lg0KPiAN
Cj4gVGhlIGlzc3VlIGhlIHdhcyB0cnlpbmcgdG8gZml4IHdhcyB0aGF0IHRoZSBjcHUgd2FzIG9u
bGluZSBidXQgbm90IGFjdGl2ZSwgd2hpY2gNCj4gY29uZnVzZWQgdGhlIHNjaGVkdWxlci4NCj4g
DQo+IEkgdGhpbmsgQW50b24gbWlzc2VkIHRoYXQgd2UgaGF2ZSBhIGxvb3AgdGhhdCB3YWl0cyBm
b3Igb25saW5lIGF0IHRoZSBib3R0b20gb2YNCj4gX19jcHVfdXAoKToNCj4gDQo+IAkvKiBXYWl0
IHVudGlsIGNwdSBwdXRzIGl0c2VsZiBpbiB0aGUgb25saW5lIG1hcCAqLw0KPiAJd2hpbGUgKCFj
cHVfb25saW5lKGNwdSkpDQo+IAkJY3B1X3JlbGF4KCk7DQo+IA0KPiANCj4gSGUgbXVzdCBoYXZl
IHNlZW4gYSBjYXNlIHdoZXJlIHRoYXQgcG9wcGVkIGR1ZSB0byB0aGUgY3B1IGJlaW5nIG9ubGlu
ZSwgYnV0IHRoZQ0KPiBjcHUgd2Fzbid0IHlldCBhY3RpdmUuDQo+IA0KPiBIaXMgcGF0Y2ggZml4
ZWQgdGhlIHByb2JsZW0gYnkgZW5zdXJpbmcgdGhlIHByZXZpb3VzIGxvb3AgdGhhdCB3YWl0cyBm
b3INCj4gY3B1X2NhbGxpbl9tYXAgZG9lc24ndCBmaW5pc2ggdW50aWwgYWN0aXZlICYgb25saW5l
IGFyZSBzZXQsIG1ha2luZyB0aGUgd2hpbGUNCj4gbG9vcCBhYm92ZSBhIG5vcC4NCj4gDQo+IFNv
IEkgdGhpbmsgd2Ugc2hvdWxkIHByb2JhYmx5IHJldmVydCBBbnRvbidzIHBhdGNoIGFuZCBpbnN0
ZWFkIGNoYW5nZSB0aGF0IHdoaWxlDQo+IGxvb3AgdG86DQo+IA0KPiAJLyogV2FpdCB1bnRpbCBj
cHUgaXMgb25saW5lIEFORCBhY3RpdmUgKi8NCj4gCXdoaWxlICghY3B1X29ubGluZShjcHUpIHx8
ICFjcHVfYWN0aXZlKGNwdSkpDQo+IAkJY3B1X3JlbGF4KCk7DQo+IA0KVW1tLi4gU29ycnkgYWJv
dXQgdGhhdC4uLkkgZm9yZ290IEFudG9uJ3MgcGF0Y2guDQoNCkJ1dCBzZXRfY3B1X29ubGluZSBh
bHNvIHNldCBjcHVfYWN0aXZlX2JpdHMsIEkgdGhpbmsgdGhpcyBqdWRnbWVudCBjYW5ub3QgZml4
IEFudG9uJ3MgaXNzdWUuDQpJdCBpcyBhY3R1YWxseSB0aGUgZWZmZWN0cyBvZiB0aGUgb3JpZ2lu
YWwgaXMgdGhlIHNhbWUuDQoNClJlZ3JhZHMsDQotRG9uZ3NoZW5nDQoNCg==
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-23 5:45 ` Michael Ellerman
2014-12-23 6:53 ` Dongsheng.Wang
@ 2014-12-23 7:55 ` Dongsheng.Wang
1 sibling, 0 replies; 9+ messages in thread
From: Dongsheng.Wang @ 2014-12-23 7:55 UTC (permalink / raw)
To: Dongsheng.Wang@freescale.com, Michael Ellerman
Cc: Scott Wood, linuxppc-dev@lists.ozlabs.org, anton@samba.org
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV2FuZyBEb25nc2hlbmct
QjQwNTM0DQo+IFNlbnQ6IFR1ZXNkYXksIERlY2VtYmVyIDIzLCAyMDE0IDI6NTMgUE0NCj4gVG86
ICdNaWNoYWVsIEVsbGVybWFuJw0KPiBDYzogYmVuaEBrZXJuZWwuY3Jhc2hpbmcub3JnOyBXb29k
IFNjb3R0LUIwNzQyMTsgYW50b25Ac2FtYmEub3JnOyBsaW51eHBwYy0NCj4gZGV2QGxpc3RzLm96
bGFicy5vcmcNCj4gU3ViamVjdDogUkU6IFtQQVRDSF0gcG93ZXJwYy9zbXA6IEZpeCBOb24tYm9v
dCBjcHVzIGNhbm5vdCBiZSBicmluZyB1cC4NCj4gDQo+IA0KPiANCj4gPiAtLS0tLU9yaWdpbmFs
IE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IE1pY2hhZWwgRWxsZXJtYW4gW21haWx0bzptcGVAZWxs
ZXJtYW4uaWQuYXVdDQo+ID4gU2VudDogVHVlc2RheSwgRGVjZW1iZXIgMjMsIDIwMTQgMTo0NiBQ
TQ0KPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQNCj4gPiBDYzogYmVuaEBrZXJuZWwuY3Jh
c2hpbmcub3JnOyBXb29kIFNjb3R0LUIwNzQyMTsgYW50b25Ac2FtYmEub3JnOw0KPiA+IGxpbnV4
cHBjLSBkZXZAbGlzdHMub3psYWJzLm9yZw0KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2Vy
cGMvc21wOiBGaXggTm9uLWJvb3QgY3B1cyBjYW5ub3QgYmUgYnJpbmcgdXAuDQo+ID4NCj4gPiBP
biBUdWUsIDIwMTQtMTItMjMgYXQgMDI6NDEgKzAwMDAsIERvbmdzaGVuZy5XYW5nQGZyZWVzY2Fs
ZS5jb20gd3JvdGU6DQo+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+
IEZyb206IE1pY2hhZWwgRWxsZXJtYW4gW21haWx0bzptcGVAZWxsZXJtYW4uaWQuYXVdDQo+ID4g
PiA+IFNlbnQ6IFR1ZXNkYXksIERlY2VtYmVyIDIzLCAyMDE0IDk6MDEgQU0NCj4gPiA+ID4gVG86
IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiA+ID4gPiBDYzogYmVuaEBrZXJuZWwuY3Jhc2hpbmcu
b3JnOyBXb29kIFNjb3R0LUIwNzQyMTsgYW50b25Ac2FtYmEub3JnOw0KPiA+ID4gPiBsaW51eHBw
Yy0gZGV2QGxpc3RzLm96bGFicy5vcmcNCj4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSF0gcG93
ZXJwYy9zbXA6IEZpeCBOb24tYm9vdCBjcHVzIGNhbm5vdCBiZSBicmluZyB1cC4NCj4gPiA+ID4N
Cj4gPiA+ID4gT24gTW9uLCAyMDE0LTEyLTIyIGF0IDE0OjM4ICswODAwLCBEb25nc2hlbmcgV2Fu
ZyB3cm90ZToNCj4gPiA+ID4gPiBGcm9tOiBXYW5nIERvbmdzaGVuZyA8ZG9uZ3NoZW5nLndhbmdA
ZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEtlcm5lbCBjYW5ub3QgYnJpbmcg
dXAgTm9uLWJvb3QgY3B1cyBhbHdheXMgZ2V0ICJQcm9jZXNzb3IgeHggaXMgc3R1Y2siLg0KPiA+
ID4gPiA+IHRoaXMgaXNzdWUgYnJpbmcgYnkgaHR0cDovL3BhdGNod29yay5vemxhYnMub3JnL3Bh
dGNoLzQxODkxMi8gKHBvd2VycGM6DQo+ID4gPiA+ID4gU2Vjb25kYXJ5IENQVXMgbXVzdCBzZXQg
Y3B1X2NhbGxpbl9tYXAgYWZ0ZXIgc2V0dGluZyBhY3RpdmUgYW5kDQo+ID4gPiA+ID4gb25saW5l
KSBXZSBuZWVkIHRvIHRha2UgdGltZWJhc2UgYWZ0ZXIgYm9vdHVwIGNwdSBnaXZlIHRoZQ0KPiA+
ID4gPiA+IHRpbWViYXNlDQo+ID4gZmlyc3RseS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFdoZW4g
c3RhcnRfc2Vjb25kYXJ5LCBub24tYm9vdCBjcHVzIHNldCBjcHVfY2FsbGluX21hcCBmb3IgYm9v
dA0KPiA+ID4gPiA+IGNwdSBhZnRlciB0aGF0IGJvb3QgY3B1IHdpbGwgZ2l2ZSB0aGUgdGltZWJh
c2UgZm9yIG5vbi1ib290IGNwdS4NCj4gPiA+ID4gPiBPdGhlcndpc2Ugbm9uLWJvb3QgY3B1cyB3
aWxsIGZhbGwgaW4gZGVhZCBsb29wIHRvIHdhaXRpbmcgYm9vdHVwDQo+ID4gPiA+ID4gY3B1IHRv
IGdpdmUgaW1lYmFzZS4NCj4gPiA+ID4NCj4gPiA+ID4gUmlnaHQuDQo+ID4gPiA+DQo+ID4gPiA+
IEhvd2V2ZXIsIGRvZXNuJ3QgdGhpcyBpbnRyb2R1Y2UgdGhlIHBvc3NpYmlsaXR5IHRoYXQgdGhl
IHNlY29uZGFyeQ0KPiA+ID4gPiBjcHUgaXMgdXAgYW5kIG1hcmtlZCBvbmxpbmUgYnV0IGhhcyBh
biB1bnN5bmNocm9uaXNlZCBjbG9jaz8NCj4gPg0KPiA+ID4gWWVzLCByaWdodC4gQnV0IEZyZWVz
Y2FsZSBwbGF0Zm9ybSBib290LWNwdSB3aWxsIGZyZWV6ZSB0aGUgVEIgdW50aWwNCj4gPiA+IHNl
Y29uZGFyeSBjcHUgdGFrZSB0aGUgdGltZSBiYXNlLCBzbyB0aGUgY2xvY2sgaXMgc3luY2hyb25p
emVkLg0KPiA+DQo+ID4gSXQgZG9lcyB0aGUgZnJlZXplIGluIGdpdmVfdGltZWJhc2UoKSBkb2Vz
bid0IGl0Pw0KPiA+DQo+ID4gU28gdGhlcmUncyBzdGlsbCBhIHdpbmRvdyB0aGVyZSB3aGVyZSB0
aGUgc2Vjb25kYXJ5IGlzIHVwICYgb25saW5lIGJ1dA0KPiA+IGhhc24ndCBoYWQgaXQncyB0aW1l
YmFzZSBzeW5jaHJvbmlzZWQsIGFuZCB0aGUgcHJpbWFyeSBoYXNuJ3QgZnJvemVuIHRoZQ0KPiB0
aW1lYmFzZSB5ZXQuDQo+ID4gU28gdGhhdCBtYWtlcyBtZSBuZXJ2b3VzLg0KPiA+DQo+ID4gPiBG
b3IgZ2VuZXJpYyBQb3dlclBDIG1heWJlIGhhcyB0aGlzIGlzc3VlLiBTbyBmb3Igc2FmZSBJIHRo
aW5rIHdlDQo+ID4gPiBuZWVkIHRvIHNldCBjcHUgb25saW5lIGFmdGVyIHN5bmNocm9uaXplZCBj
bG9jay4NCj4gPiA+DQo+ID4gPiBJIHdpbGwgdXBkYXRlIG15IHBhdGNoIGlmIHlvdSBhZ3JlZSB0
aGlzIHdheS4NCj4gPiA+ICsgICAgICAgaWYgKHNtcF9vcHMtPnRha2VfdGltZWJhc2UpDQo+ID4g
PiArICAgICAgICAgICAgICAgc21wX29wcy0+dGFrZV90aW1lYmFzZSgpOw0KPiA+ID4gKyAgICAg
ICBzZWNvbmRhcnlfY3B1X3RpbWVfaW5pdCgpOw0KPiA+ID4gKw0KPiA+ID4gTW92ZSBzZXRfY3B1
X29ubGluZSB0byBoZXJlLg0KPiA+ID4gKyAgICAgICBzZXRfY3B1X29ubGluZShjcHUsIHRydWUp
Ow0KPiA+DQo+ID4gQnV0IHRoYXQgcmV2ZXJzZXMgdGhlIGVmZmVjdCBvZiB0aGUgb3JpZ2luYWwg
cGF0Y2gsIHdoaWNoIHdhcyB0aGF0IHdlDQo+ID4gaGF2ZSB0byBzZXQgb25saW5lICpiZWZvcmUq
IHdlIHNldCB0aGUgY2FsbGluIG1hcC4NCj4gPg0KPiA+DQo+ID4gTG9va2luZyBoYXJkZXIgYXQg
QW50b24ncyBwYXRjaCBJJ20gbm90IHN1cmUgaXQncyByaWdodCBhbnl3YXkuDQo+ID4NCj4gPiBU
aGUgaXNzdWUgaGUgd2FzIHRyeWluZyB0byBmaXggd2FzIHRoYXQgdGhlIGNwdSB3YXMgb25saW5l
IGJ1dCBub3QNCj4gPiBhY3RpdmUsIHdoaWNoIGNvbmZ1c2VkIHRoZSBzY2hlZHVsZXIuDQo+ID4N
Cj4gPiBJIHRoaW5rIEFudG9uIG1pc3NlZCB0aGF0IHdlIGhhdmUgYSBsb29wIHRoYXQgd2FpdHMg
Zm9yIG9ubGluZSBhdCB0aGUNCj4gPiBib3R0b20gb2YNCj4gPiBfX2NwdV91cCgpOg0KPiA+DQo+
ID4gCS8qIFdhaXQgdW50aWwgY3B1IHB1dHMgaXRzZWxmIGluIHRoZSBvbmxpbmUgbWFwICovDQo+
ID4gCXdoaWxlICghY3B1X29ubGluZShjcHUpKQ0KPiA+IAkJY3B1X3JlbGF4KCk7DQo+ID4NCj4g
Pg0KPiA+IEhlIG11c3QgaGF2ZSBzZWVuIGEgY2FzZSB3aGVyZSB0aGF0IHBvcHBlZCBkdWUgdG8g
dGhlIGNwdSBiZWluZw0KPiA+IG9ubGluZSwgYnV0IHRoZSBjcHUgd2Fzbid0IHlldCBhY3RpdmUu
DQo+ID4NCj4gPiBIaXMgcGF0Y2ggZml4ZWQgdGhlIHByb2JsZW0gYnkgZW5zdXJpbmcgdGhlIHBy
ZXZpb3VzIGxvb3AgdGhhdCB3YWl0cw0KPiA+IGZvciBjcHVfY2FsbGluX21hcCBkb2Vzbid0IGZp
bmlzaCB1bnRpbCBhY3RpdmUgJiBvbmxpbmUgYXJlIHNldCwNCj4gPiBtYWtpbmcgdGhlIHdoaWxl
IGxvb3AgYWJvdmUgYSBub3AuDQo+ID4NCj4gPiBTbyBJIHRoaW5rIHdlIHNob3VsZCBwcm9iYWJs
eSByZXZlcnQgQW50b24ncyBwYXRjaCBhbmQgaW5zdGVhZCBjaGFuZ2UNCj4gPiB0aGF0IHdoaWxl
IGxvb3AgdG86DQo+ID4NCj4gPiAJLyogV2FpdCB1bnRpbCBjcHUgaXMgb25saW5lIEFORCBhY3Rp
dmUgKi8NCj4gPiAJd2hpbGUgKCFjcHVfb25saW5lKGNwdSkgfHwgIWNwdV9hY3RpdmUoY3B1KSkN
Cj4gPiAJCWNwdV9yZWxheCgpOw0KPiA+DQoNCkJhc2Ugb24gQW50b24ncyBwYXRjaCwgd2Ugc2hv
dWxkIHByb2JhYmx5IGNoYW5nZSBfX2N1cF91cC4NClBsZWFzZSBjb21tZW50IHRoZSBjaGFuZ2Vz
Lg0KLS0tIGEvYXJjaC9wb3dlcnBjL2tlcm5lbC9zbXAuYw0KKysrIGIvYXJjaC9wb3dlcnBjL2tl
cm5lbC9zbXAuYw0KQEAgLTUyOCwxMiArNTI4LDEwIEBAIGludCBfX2NwdV91cCh1bnNpZ25lZCBp
bnQgY3B1LCBzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRpZGxlKQ0KICAgICAgICB9DQoNCiAgICAgICAg
LyoNCi0gICAgICAgICogd2FpdCB0byBzZWUgaWYgdGhlIGNwdSBtYWRlIGEgY2FsbGluIChpcyBh
Y3R1YWxseSB1cCkuDQotICAgICAgICAqIHVzZSB0aGlzIHZhbHVlIHRoYXQgSSBmb3VuZCB0aHJv
dWdoIGV4cGVyaW1lbnRhdGlvbi4NCi0gICAgICAgICogLS0gQ29ydA0KKyAgICAgICAgKiBXYWl0
IHVudGlsIGNwdSBwdXRzIGl0c2VsZiBpbiB0aGUgb25saW5lIG1hcA0KICAgICAgICAgKi8NCiAg
ICAgICAgaWYgKHN5c3RlbV9zdGF0ZSA8IFNZU1RFTV9SVU5OSU5HKQ0KLSAgICAgICAgICAgICAg
IGZvciAoYyA9IDUwMDAwOyBjICYmICFjcHVfY2FsbGluX21hcFtjcHVdOyBjLS0pDQorICAgICAg
ICAgICAgICAgZm9yIChjID0gNTAwMDA7IGMgJiYgIWNwdV9vbmxpbmUoY3B1KTsgYy0tKQ0KICAg
ICAgICAgICAgICAgICAgICAgICAgdWRlbGF5KDEwMCk7DQogI2lmZGVmIENPTkZJR19IT1RQTFVH
X0NQVQ0KICAgICAgICBlbHNlDQpAQCAtNTQxLDExICs1MzksMTAgQEAgaW50IF9fY3B1X3VwKHVu
c2lnbmVkIGludCBjcHUsIHN0cnVjdCB0YXNrX3N0cnVjdCAqdGlkbGUpDQogICAgICAgICAgICAg
ICAgICogQ1BVcyBjYW4gdGFrZSBtdWNoIGxvbmdlciB0byBjb21lIHVwIGluIHRoZQ0KICAgICAg
ICAgICAgICAgICAqIGhvdHBsdWcgY2FzZS4gIFdhaXQgZml2ZSBzZWNvbmRzLg0KICAgICAgICAg
ICAgICAgICAqLw0KLSAgICAgICAgICAgICAgIGZvciAoYyA9IDUwMDA7IGMgJiYgIWNwdV9jYWxs
aW5fbWFwW2NwdV07IGMtLSkNCisgICAgICAgICAgICAgICBmb3IgKGMgPSA1MDAwOyBjICYmICFj
cHVfb25saW5lKGNwdSk7IGMtLSkNCiAgICAgICAgICAgICAgICAgICAgICAgIG1zbGVlcCgxKTsN
CiAjZW5kaWYNCi0NCi0gICAgICAgaWYgKCFjcHVfY2FsbGluX21hcFtjcHVdKSB7DQorICAgICAg
IGlmICghY3B1X29ubGluZShjcHUpKSB7DQogICAgICAgICAgICAgICAgcHJpbnRrKEtFUk5fRVJS
ICJQcm9jZXNzb3IgJXUgaXMgc3R1Y2suXG4iLCBjcHUpOw0KICAgICAgICAgICAgICAgIHJldHVy
biAtRU5PRU5UOw0KICAgICAgICB9DQpAQCAtNTU1LDggKzU1Miw4IEBAIGludCBfX2NwdV91cCh1
bnNpZ25lZCBpbnQgY3B1LCBzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRpZGxlKQ0KICAgICAgICBpZiAo
c21wX29wcy0+Z2l2ZV90aW1lYmFzZSkNCiAgICAgICAgICAgICAgICBzbXBfb3BzLT5naXZlX3Rp
bWViYXNlKCk7DQoNCi0gICAgICAgLyogV2FpdCB1bnRpbCBjcHUgcHV0cyBpdHNlbGYgaW4gdGhl
IG9ubGluZSBtYXAgKi8NCi0gICAgICAgd2hpbGUgKCFjcHVfb25saW5lKGNwdSkpDQorICAgICAg
IC8qIFdhaXQgdW50aWwgY3B1IHN5bmNocm9uaXplZCBjbG9jayAqLw0KKyAgICAgICB3aGlsZSAo
IWNwdV9jYWxsaW5fbWFwW2NwdV0pDQogICAgICAgICAgICAgICAgY3B1X3JlbGF4KCk7DQoNCiAg
ICAgICAgcmV0dXJuIDA7DQpAQCAtNzAzLDEwICs3MDAsNiBAQCB2b2lkIHN0YXJ0X3NlY29uZGFy
eSh2b2lkICp1bnVzZWQpDQoNCiAgICAgICAgaWYgKHNtcF9vcHMtPnNldHVwX2NwdSkNCiAgICAg
ICAgICAgICAgICBzbXBfb3BzLT5zZXR1cF9jcHUoY3B1KTsNCi0gICAgICAgaWYgKHNtcF9vcHMt
PnRha2VfdGltZWJhc2UpDQotICAgICAgICAgICAgICAgc21wX29wcy0+dGFrZV90aW1lYmFzZSgp
Ow0KLQ0KLSAgICAgICBzZWNvbmRhcnlfY3B1X3RpbWVfaW5pdCgpOw0KDQogI2lmZGVmIENPTkZJ
R19QUEM2NA0KICAgICAgICBpZiAoc3lzdGVtX3N0YXRlID09IFNZU1RFTV9SVU5OSU5HKQ0KQEAg
LTczOCw2ICs3MzEsMTAgQEAgdm9pZCBzdGFydF9zZWNvbmRhcnkodm9pZCAqdW51c2VkKQ0KICAg
ICAgICBub3RpZnlfY3B1X3N0YXJ0aW5nKGNwdSk7DQogICAgICAgIHNldF9jcHVfb25saW5lKGNw
dSwgdHJ1ZSk7DQoNCisgICAgICAgaWYgKHNtcF9vcHMtPnRha2VfdGltZWJhc2UpDQorICAgICAg
ICAgICAgICAgc21wX29wcy0+dGFrZV90aW1lYmFzZSgpOw0KKw0KKyAgICAgICBzZWNvbmRhcnlf
Y3B1X3RpbWVfaW5pdCgpOw0KICAgICAgICAvKg0KICAgICAgICAgKiBDUFUgbXVzdCBiZSBtYXJr
ZWQgYWN0aXZlIGFuZCBvbmxpbmUgYmVmb3JlIHdlIHNpZ25hbCBiYWNrIHRvIHRoZQ0KICAgICAg
ICAgKiBtYXN0ZXIsIGJlY2F1c2UgdGhlIHNjaGVkdWxlciBuZWVkcyB0byBzZWUgdGhlIGNwdV9v
bmxpbmUgYW5kDQoNClJlZ2FyZHMsDQotRG9uZ3NoZW5nDQoNCj4gVW1tLi4gU29ycnkgYWJvdXQg
dGhhdC4uLkkgZm9yZ290IEFudG9uJ3MgcGF0Y2guDQo+IA0KPiBCdXQgc2V0X2NwdV9vbmxpbmUg
YWxzbyBzZXQgY3B1X2FjdGl2ZV9iaXRzLCBJIHRoaW5rIHRoaXMganVkZ21lbnQgY2Fubm90IGZp
eA0KPiBBbnRvbidzIGlzc3VlLg0KPiBJdCBpcyBhY3R1YWxseSB0aGUgZWZmZWN0cyBvZiB0aGUg
b3JpZ2luYWwgaXMgdGhlIHNhbWUuDQo+IA0KPiBSZWdyYWRzLA0KPiAtRG9uZ3NoZW5nDQoNCg==
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-23 1:00 ` Michael Ellerman
2014-12-23 2:41 ` Dongsheng.Wang
@ 2014-12-23 9:55 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2014-12-23 9:55 UTC (permalink / raw)
To: Michael Ellerman; +Cc: scottwood, linuxppc-dev, Dongsheng Wang, anton
On Tue, 2014-12-23 at 12:00 +1100, Michael Ellerman wrote:
> On Mon, 2014-12-22 at 14:38 +0800, Dongsheng Wang wrote:
> > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> >
> > Kernel cannot bring up Non-boot cpus always get "Processor xx is stuck".
> > this issue bring by http://patchwork.ozlabs.org/patch/418912/ (powerpc:
> > Secondary CPUs must set cpu_callin_map after setting active and online)
> > We need to take timebase after bootup cpu give the timebase firstly.
> >
> > When start_secondary, non-boot cpus set cpu_callin_map for boot cpu
> > after that boot cpu will give the timebase for non-boot cpu. Otherwise
> > non-boot cpus will fall in dead loop to waiting bootup cpu to give
> > imebase.
>
> Right.
>
> However, doesn't this introduce the possibility that the secondary cpu is up
> and marked online but has an unsynchronised clock?
As long as it doesn't execute anything (and at that point it shouldn't
have interrupts enabled) it should be ok. The TB cannot be observed
outside of that CPU.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-22 6:38 [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up Dongsheng Wang
2014-12-23 1:00 ` Michael Ellerman
@ 2014-12-26 12:09 ` Aaro Koskinen
2014-12-29 9:01 ` Michael Ellerman
2 siblings, 0 replies; 9+ messages in thread
From: Aaro Koskinen @ 2014-12-26 12:09 UTC (permalink / raw)
To: Dongsheng Wang; +Cc: scottwood, linuxppc-dev, anton
Hi,
On Mon, Dec 22, 2014 at 02:38:40PM +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> Kernel cannot bring up Non-boot cpus always get "Processor xx is stuck".
> this issue bring by http://patchwork.ozlabs.org/patch/418912/ (powerpc:
> Secondary CPUs must set cpu_callin_map after setting active and online)
> We need to take timebase after bootup cpu give the timebase firstly.
>
> When start_secondary, non-boot cpus set cpu_callin_map for boot cpu
> after that boot cpu will give the timebase for non-boot cpu. Otherwise
> non-boot cpus will fall in dead loop to waiting bootup cpu to give
> imebase.
>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
This fixes v3.19-rc1 boot on G5 Xserve.
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up.
2014-12-22 6:38 [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up Dongsheng Wang
2014-12-23 1:00 ` Michael Ellerman
2014-12-26 12:09 ` Aaro Koskinen
@ 2014-12-29 9:01 ` Michael Ellerman
2 siblings, 0 replies; 9+ messages in thread
From: Michael Ellerman @ 2014-12-29 9:01 UTC (permalink / raw)
To: Dongsheng Wang; +Cc: scottwood, linuxppc-dev, anton
On Mon, 2014-12-22 at 14:38 +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> Kernel cannot bring up Non-boot cpus always get "Processor xx is stuck".
> this issue bring by http://patchwork.ozlabs.org/patch/418912/ (powerpc:
> Secondary CPUs must set cpu_callin_map after setting active and online)
We've decided we're just going to revert that patch for this cycle.
We'll do a better fix for next, and hopefully people will test it before it
gets to mainline :D
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-12-29 9:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 6:38 [PATCH] powerpc/smp: Fix Non-boot cpus cannot be bring up Dongsheng Wang
2014-12-23 1:00 ` Michael Ellerman
2014-12-23 2:41 ` Dongsheng.Wang
2014-12-23 5:45 ` Michael Ellerman
2014-12-23 6:53 ` Dongsheng.Wang
2014-12-23 7:55 ` Dongsheng.Wang
2014-12-23 9:55 ` Benjamin Herrenschmidt
2014-12-26 12:09 ` Aaro Koskinen
2014-12-29 9:01 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.