All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 1/3] image_types.bbclass: Respect IMAGE_TYPEDEP dependencies
Date: Wed, 24 Dec 2014 08:46:09 +0000	[thread overview]
Message-ID: <1419410769.6428.15.camel@linuxfoundation.org> (raw)
In-Reply-To: <1418159277-3620-1-git-send-email-otavio@ossystems.com.br>

On Tue, 2014-12-09 at 19:07 -0200, Otavio Salvador wrote:
> The IMAGE_TYPEDEP dependencies also need to be taken into account when
> building an IMAGE_FSTYPE.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  meta/classes/image_types.bbclass | 2 ++
>  1 file changed, 2 insertions(+)

According to my tests, something in this patch series is causing:

https://autobuilder.yoctoproject.org/main/builders/minnow/builds/137/steps/BuildImages/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/minnow-lsb/builds/138/steps/BuildImages/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/nightly-x86/builds/137/steps/BuildImages_1/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/nightly-x86-64/builds/138/steps/BuildImages_1/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/nightly-x86-lsb/builds/138/steps/BuildImages_1/logs/stdio

I could reproduce locally just by building anything with a live image
type and executing do_bootimg. It appears the ".gz" version of the
initramfs isn't created. You have to force stamps to get the code to
rerun.

Cheers,

Richard

> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 9aee745..24e4bbb 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -21,6 +21,8 @@ def imagetypes_getdepends(d):
>                  basetype = type[:-len("." + ctype)]
>                  adddep(d.getVar("COMPRESS_DEPENDS_%s" % ctype, True), deps)
>                  break
> +        for typedepends in (d.getVar("IMAGE_TYPEDEP_%s" % basetype, True) or "").split():
> +            adddep(d.getVar('IMAGE_DEPENDS_%s' % typedepends, True) , deps)
>          adddep(d.getVar('IMAGE_DEPENDS_%s' % basetype, True) , deps)
>  
>      depstr = ""




  parent reply	other threads:[~2014-12-24  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 21:07 [PATCH v2 1/3] image_types.bbclass: Respect IMAGE_TYPEDEP dependencies Otavio Salvador
2014-12-09 21:07 ` [PATCH v2 2/3] image_types.bbclass: Rework code to map types for 'ext3' Otavio Salvador
2014-12-09 21:07 ` [PATCH v2 3/3] lib/oe/image.py: Handle compressed IMAGE_TYPEDEP values Otavio Salvador
2014-12-24  8:46 ` Richard Purdie [this message]
2014-12-24 16:32   ` [PATCH v2 1/3] image_types.bbclass: Respect IMAGE_TYPEDEP dependencies Otavio Salvador
  -- strict thread matches above, loose matches on Subject: below --
2014-12-24 16:32 Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419410769.6428.15.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.