From: Joe Perches <joe@perches.com>
To: arno.tiemersma@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: skein: Fix checkpatch warnings
Date: Thu, 25 Dec 2014 10:06:22 -0800 [thread overview]
Message-ID: <1419530782.6157.15.camel@perches.com> (raw)
In-Reply-To: <1419530490-32316-1-git-send-email-arno.tiemersma@gmail.com>
On Thu, 2014-12-25 at 19:01 +0100, arno.tiemersma@gmail.com wrote:
> Remove do {} while (0) loops around single statements in
> skein/skein_block.c
[]
> diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
[]
> @@ -83,9 +83,7 @@ do { \
> #else
> /* looping version */
> #define R256(p0, p1, p2, p3, ROT, r_num) \
> -do { \
> ROUND256(p0, p1, p2, p3, ROT, r_num); \
When you do these things, you also have to
remove the trailing semi-colon and the
line continuation '\' as well.
next prev parent reply other threads:[~2014-12-25 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 18:01 [PATCH] staging: skein: Fix checkpatch warnings arno.tiemersma
2014-12-25 18:06 ` Joe Perches [this message]
2014-12-25 18:15 ` [PATCH v2] " Arno Tiemersma
-- strict thread matches above, loose matches on Subject: below --
2015-01-10 15:00 [PATCH] " Arno Tiemersma
2015-01-12 14:14 ` Jason Cooper
2015-01-12 14:33 ` Dan Carpenter
2015-01-12 14:40 ` Jason Cooper
2015-01-17 23:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419530782.6157.15.camel@perches.com \
--to=joe@perches.com \
--cc=arno.tiemersma@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.