All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Kelly <dougk.ff7@gmail.com>
To: git@vger.kernel.org
Cc: Doug Kelly <dougk.ff7@gmail.com>
Subject: [PATCH 2/2] format-patch: ignore diff.submodule setting
Date: Fri, 26 Dec 2014 17:11:46 -0600	[thread overview]
Message-ID: <1419635506-5045-3-git-send-email-dougk.ff7@gmail.com> (raw)
In-Reply-To: <1419635506-5045-1-git-send-email-dougk.ff7@gmail.com>

diff.submodule when set to log produces output which git-am cannot
handle. Ignore this setting when generating patch output.

Signed-off-by: Doug Kelly <dougk.ff7@gmail.com>
---
 builtin/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/log.c b/builtin/log.c
index 734aab3..cb14db4 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -705,7 +705,7 @@ static int git_format_config(const char *var, const char *value, void *cb)
 		return 0;
 	}
 	if (!strcmp(var, "diff.color") || !strcmp(var, "color.diff") ||
-	    !strcmp(var, "color.ui")) {
+	    !strcmp(var, "color.ui") || !strcmp(var, "diff.submodule")) {
 		return 0;
 	}
 	if (!strcmp(var, "format.numbered")) {
-- 
2.0.5

  parent reply	other threads:[~2014-12-26 23:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-26 23:11 [PATCH 0/2] Fix issue with format-patch and diff.submodule Doug Kelly
2014-12-26 23:11 ` [PATCH 1/2] t4255: test am submodule with diff.submodule Doug Kelly
2014-12-28  0:37   ` Eric Sunshine
2014-12-28  1:00     ` Doug Kelly
2014-12-29 15:42     ` Junio C Hamano
2015-01-07 19:34       ` Doug Kelly
2015-01-07 20:20         ` Junio C Hamano
2014-12-26 23:11 ` Doug Kelly [this message]
2014-12-28  1:04 ` [PATCH v2 " Doug Kelly
2014-12-28  1:04   ` [PATCH v2 2/2] format-patch: ignore diff.submodule setting Doug Kelly
2014-12-28  2:24   ` [PATCH v2 1/2] t4255: test am submodule with diff.submodule Eric Sunshine
2015-01-07 19:31 ` [PATCH v3 " Doug Kelly
2015-01-07 19:31   ` [PATCH v3 2/2] format-patch: ignore diff.submodule setting Doug Kelly
2015-01-07 20:06   ` [PATCH v3 1/2] t4255: test am submodule with diff.submodule Eric Sunshine
2015-01-07 20:13 ` [PATCH v4 " Doug Kelly
2015-01-07 20:13   ` [PATCH v4 2/2] format-patch: ignore diff.submodule setting Doug Kelly
2015-01-07 20:32 ` [PATCH v5 1/2] t4255: test am submodule with diff.submodule Doug Kelly
2015-01-07 20:32   ` [PATCH v5 2/2] format-patch: ignore diff.submodule setting Doug Kelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419635506-5045-3-git-send-email-dougk.ff7@gmail.com \
    --to=dougk.ff7@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.