From: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH v2] Fix rte_is_power_of_2
Date: Sat, 27 Dec 2014 10:30:44 -0500 [thread overview]
Message-ID: <1419694244-2018-1-git-send-email-rkerur@gmail.com> (raw)
In-Reply-To: <1419694115-1892-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
rte_is_power_of_2 returns true for 0 and 0 is not power_of_2. Fix
by checking for n.
Signed-off-by: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
lib/librte_eal/common/include/rte_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
index 921b91f..8ac940c 100644
--- a/lib/librte_eal/common/include/rte_common.h
+++ b/lib/librte_eal/common/include/rte_common.h
@@ -203,7 +203,7 @@ extern int RTE_BUILD_BUG_ON_detected_error;
static inline int
rte_is_power_of_2(uint32_t n)
{
- return ((n-1) & n) == 0;
+ return n && !(n & (n - 1));
}
/**
--
1.9.1
next prev parent reply other threads:[~2014-12-27 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 15:28 [PATCH v2] Fix rte_is_power_of_2 Ravi Kerur
[not found] ` <1419694115-1892-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-27 15:30 ` Ravi Kerur [this message]
[not found] ` <1419694244-2018-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-27 20:49 ` Neil Horman
[not found] ` <20141227204903.GB16138-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-01-15 13:12 ` Thomas Monjalon
2015-01-19 2:45 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EA935-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-19 7:21 ` David Marchand
[not found] ` <CALwxeUu2YOFUeQ3urHxFk+3mYef0zyiZMCDnYTsiJ7o9K0Pzhw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-19 9:13 ` Thomas Monjalon
2015-01-19 9:30 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286CB74C5-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-19 9:49 ` David Marchand
2015-01-19 10:02 ` Qiu, Michael
2015-01-19 10:07 ` Qiu, Michael
2015-01-19 17:07 ` Ravi Kerur
[not found] ` <CAFb4SLBf+PTwOwstD6LBzTimF08pcycWsSP5+pHNuT+_6kZRew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-19 22:07 ` Ravi Kerur
2015-01-19 9:14 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419694244-2018-1-git-send-email-rkerur@gmail.com \
--to=rkerur-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.