From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-kernel@vger.kernel.org,
Evgeniy Dushistov <dushistov@mail.ru>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] fs/ufs/super.c: remove unnecessary casting
Date: Sun, 28 Dec 2014 08:45:44 -0800 [thread overview]
Message-ID: <1419785144.20894.10.camel@perches.com> (raw)
In-Reply-To: <20141228153311.GI22149@ZenIV.linux.org.uk>
On Sun, 2014-12-28 at 15:33 +0000, Al Viro wrote:
> On Sun, Dec 28, 2014 at 04:28:29PM +0100, Fabian Frederick wrote:
> > Fix the following coccinelle warning:
> > fs/ufs/super.c:1418:7-28: WARNING: casting value returned by memory
> > allocation function to (struct ufs_inode_info *) is useless.
>
> ... except that it makes allocations harder to grep for.
How does it do that?
> IOW, it's not
> obviously an improvement and should be up to maintainer of the code in
> question.
That's always true in any case.
next prev parent reply other threads:[~2014-12-28 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 15:28 [PATCH 1/1] fs/ufs/super.c: remove unnecessary casting Fabian Frederick
2014-12-28 15:33 ` Al Viro
2014-12-28 16:45 ` Joe Perches [this message]
2014-12-28 18:21 ` Al Viro
2014-12-31 8:46 ` Fabian Frederick
2014-12-28 16:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419785144.20894.10.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dushistov@mail.ru \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.