From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] raw/skeleton_rawdev: fix device start test Date: Mon, 05 Feb 2018 15:10:37 +0100 Message-ID: <14198513.UUEtOtHhuI@xps> References: <20180205112425.17579-1-shreyansh.jain@nxp.com> <20180205113108.19340-1-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Shreyansh Jain Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3406B1B3D5 for ; Mon, 5 Feb 2018 15:10:42 +0100 (CET) In-Reply-To: <20180205113108.19340-1-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/02/2018 12:31, Shreyansh Jain: > Device can only be started if firmware is loaded, as per Skeleton > rawdev driver semantics. This patch fixes original implementation > which attempted to start the device without loading firmware. > > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") > Cc: shreyansh.jain@nxp.com > > Signed-off-by: Shreyansh Jain > --- > v3: > - Moving 'Fixes' below commit message > - patch headline made specific > > v2: > - Fixed headline from drivers/raw to raw/skeleton_rawdev Actually, it should be raw/skeleton because it is shorter and it is what was chosen for previous commits :)