All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] phy: miphy28lp: unlock on error in miphy28lp_init()
Date: Wed, 31 Dec 2014 14:15:47 +0530	[thread overview]
Message-ID: <1420015549-20697-2-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1420015549-20697-1-git-send-email-kishon@ti.com>

From: Dan Carpenter <dan.carpenter@oracle.com>

We need to unlock before returning the -EINVAL here.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/phy-miphy28lp.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
index e34da13..27fa62c 100644
--- a/drivers/phy/phy-miphy28lp.c
+++ b/drivers/phy/phy-miphy28lp.c
@@ -1050,7 +1050,8 @@ static int miphy28lp_init(struct phy *phy)
 		ret = miphy28lp_init_usb3(miphy_phy);
 		break;
 	default:
-		return -EINVAL;
+		ret = -EINVAL;
+		break;
 	}
 
 	mutex_unlock(&miphy_dev->miphy_mutex);
-- 
1.7.9.5


  reply	other threads:[~2014-12-31  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-31  8:45 [GIT PULL 0/3] phy: fixes for 3.19 -rc cycle Kishon Vijay Abraham I
2014-12-31  8:45 ` Kishon Vijay Abraham I [this message]
2014-12-31  8:45 ` [PATCH 2/3] phy-sun4i-usb: Change disconnect threshold value for sun6i Kishon Vijay Abraham I
2014-12-31  8:45 ` [PATCH 3/3] phy: phy-ti-pipe3: fix inconsistent enumeration of PCIe gen2 cards Kishon Vijay Abraham I
2015-01-09 14:02 ` [GIT PULL 0/3] phy: fixes for 3.19 -rc cycle Kishon Vijay Abraham I
2015-01-09 17:44 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420015549-20697-2-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.