All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seunghun Lee <waydi1@gmail.com>
To: miklos@szeredi.hu
Cc: richard.weinberger@gmail.com, sedat.dilek@gmail.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Seunghun Lee <waydi1@gmail.com>
Subject: [PATCH] ovl: Prevent rw remount when it should be ro mount
Date: Fri,  2 Jan 2015 00:38:12 +0900	[thread overview]
Message-ID: <1420126692-9552-1-git-send-email-waydi1@gmail.com> (raw)

Overlayfs should be mounted read-only when upper fs is r/o or nonexistend.
But now it can be remounted read-write and this can causes kernel panic.
So we should prevent read-write remount when the above situation.

Signed-off-by: Seunghun Lee <waydi1@gmail.com>
---
 fs/overlayfs/super.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 84f3144..8944651 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -522,10 +522,21 @@ static int ovl_show_options(struct seq_file *m, struct dentry *dentry)
 	return 0;
 }
 
+static int ovl_remount(struct super_block *sb, int *flags, char *data)
+{
+	struct ovl_fs *ufs = sb->s_fs_info;
+
+	if (!ufs->upper_mnt || (ufs->upper_mnt->mnt_sb->s_flags & MS_RDONLY))
+		*flags |= MS_RDONLY;
+
+	return 0;
+}
+
 static const struct super_operations ovl_super_operations = {
 	.put_super	= ovl_put_super,
 	.statfs		= ovl_statfs,
 	.show_options	= ovl_show_options,
+	.remount_fs	= ovl_remount,
 };
 
 enum {
-- 
2.1.3


             reply	other threads:[~2015-01-01 15:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01 15:38 Seunghun Lee [this message]
2015-01-01 18:33 ` [PATCH] ovl: Prevent rw remount when it should be ro mount Sedat Dilek
2015-01-02 17:23   ` Seunghun Lee
  -- strict thread matches above, loose matches on Subject: below --
2015-01-02 17:26 Seunghun Lee
2015-01-04  2:59 ` hujianyang
2015-01-04  2:59   ` hujianyang
2015-01-06 14:02   ` Seunghun Lee
2015-01-07  2:56     ` hujianyang
2015-01-07  2:56       ` hujianyang
2015-01-07 15:04       ` Seunghun Lee
2015-01-08 13:50         ` Miklos Szeredi
2015-01-01  5:07 Seunghun Lee
2015-01-01 15:13 ` Richard Weinberger
2015-01-01 15:24   ` Sedat Dilek
2015-01-01 15:30     ` Seunghun Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420126692-9552-1-git-send-email-waydi1@gmail.com \
    --to=waydi1@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=richard.weinberger@gmail.com \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.