From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [OSSTEST PATCH 1/4] Add nested testcase of preparing and installing L1 guest VM Date: Fri, 2 Jan 2015 10:51:09 +0100 Message-ID: <1420192269.30581.42.camel@Abyss.station> References: <1418198860-29802-1-git-send-email-longtaox.pang@intel.com> <1418198860-29802-2-git-send-email-longtaox.pang@intel.com> <20141211110632.GC21659@zion.uk.xensource.com> <1419570818.28100.2.camel@localhost> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8747656870759196644==" Return-path: In-Reply-To: <1419570818.28100.2.camel@localhost> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: robert.hu@intel.com Cc: Wei Liu , Ian.Campbell@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, "longtao.pang" , di.zheng@intel.com List-Id: xen-devel@lists.xenproject.org --===============8747656870759196644== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Tmcb6MokG5AjpdwO4YI/" --=-Tmcb6MokG5AjpdwO4YI/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2014-12-26 at 13:13 +0800, Robert Hu wrote: > On Thu, 2014-12-11 at 11:06 +0000, Wei Liu wrote: > > ? > >=20 > > > die unless $entry; > > > $entry->{KernDom0}=3D $1; > > > $entry->{KernVer}=3D $2; > > > } > > > - if (m/^\s*module\s*\/(initrd\S+)/) { > > > + if (m/^\s*module\s*(?:\/boot)*\/(initrd\S+)/) { > > > $entry->{Initrd}=3D $1; > > > } > > > } > >=20 > > As I said before, this hunk should be in its own patch. > >=20 > > Just FYI, there are multiple people (Dario, you and I) touching this > > piece of code. You might want to keep an eye on main OSSTest git tree > > and rebase before reposting (and so do Dario and I). > Indeed. :-) > > > diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm > > > @@ -55,8 +55,9 @@ BEGIN { > > > target_putfilecontents_stash > > > target_putfilecontents_root_stash > > > target_put_guest_image target_editfile > > > - target_editfile_root target_file_exists > > > - target_run_apt > > > + target_editfile_root target_file_exists=20 > > > + target_file_exists_root > > > + target_run_apt > >=20 > > Please don't just change white spaces. This makes patches hard to > > review. > >=20 > > > target_install_packages target_install_package= s_norec > > > target_jobdir target_extract_jobdistpath_subdi= r > > > target_extract_jobdistpath target_guest_lv_nam= e > > > @@ -67,7 +68,7 @@ BEGIN { > > > selecthost get_hostflags get_host_property > > > get_host_native_linux_console > > > power_state power_cycle power_cycle_time > > > - serial_fetch_logs > > > + serial_fetch_logs select_ether > > > propname_massage > > > =20 > > > get_stashed open_unique_stashfile compress_sta= shed > > > @@ -109,6 +110,7 @@ BEGIN { > > > iso_gen_flags_basic > > > iso_copy_content_from_image > > > guest_editconfig_nocd > > > + guest_editconfig_cd > >=20 > > Indentation. I think we mostly use space instead of hard tab. Ian? > So what's the convention in Xen code writing? use space instead of tab? > And how many space to substitute 1 tab? I used to use 4.=20 > Xen's coding style is described in various CODING_STYLE files, within the Xen's tree. For example, for the hypervisor, this one: http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3DCODING_STYLE;h=3D95= 842e39c967ec0c100f9337ad4b245fbff1a53f;hb=3Drefs/heads/staging For libxl, this other one: http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3Dtools/libxl/CODING_= STYLE;h=3Df5b58909b34d158f4c06bb3e279f6648b1aa01ec;hb=3Drefs/heads/staging However, OSSTest is not Xen, so whatever Xen coding style is, it does not really matter here. :-) There actually is no formally defined coding style, and in fact, there is no CODING_STYLE file in OSSTest's tree. The idea is to follow the prevalent style of the file you're modifying. For instance, in case of TestSupport.pm it seems that spaces are used, and that indentation happens by means of 4 spaces. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Tmcb6MokG5AjpdwO4YI/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlSmag0ACgkQk4XaBE3IOsQURACdH8fa72tmhQErlCES26Ytlzgw +cMAn2s/tShTS62lNVNLWtNOarVUCId4 =PlpF -----END PGP SIGNATURE----- --=-Tmcb6MokG5AjpdwO4YI/-- --===============8747656870759196644== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8747656870759196644==--