All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: jitendra kumar khasdev <jkhasdev@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, pankaj.saraf@nektech.in
Subject: Re: [PATCH 1/2] Staging: comedi: tab space coding style issue in pcl818.c
Date: Fri, 02 Jan 2015 15:07:40 -0800	[thread overview]
Message-ID: <1420240060.23591.4.camel@perches.com> (raw)
In-Reply-To: <1420223689-23586-1-git-send-email-jkhasdev@gmail.com>

On Sat, 2015-01-03 at 00:04 +0530, jitendra kumar khasdev wrote:
> This is patch to the pcl818.c that fix up a use tab error
> found by the checkpatch.pl tool
[]
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
[]
> @@ -45,7 +45,7 @@ A word or two about DMA. Driver support DMA operations at two ways:
>      [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
>      [2] - DMA	(0=disable, 1, 3)
>      [3] - 0, 10=10MHz clock for 8254
> -              1= 1MHz clock for 8254
> +		1= 1MHz clock for 8254

Please look at the end result and determine
if what you've done is better or worse than
the original.



      reply	other threads:[~2015-01-02 23:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02 18:34 [PATCH 1/2] Staging: comedi: tab space coding style issue in pcl818.c jitendra kumar khasdev
2015-01-02 23:07 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420240060.23591.4.camel@perches.com \
    --to=joe@perches.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=jkhasdev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pankaj.saraf@nektech.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.