From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752557AbbACAqu (ORCPT <rfc822;w@1wt.eu>);
	Fri, 2 Jan 2015 19:46:50 -0500
Received: from smtprelay0224.hostedemail.com ([216.40.44.224]:35162 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752464AbbACAqt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 2 Jan 2015 19:46:49 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:4321:5007:6261:8660:10004:10400:10848:11026:11232:11657:11658:11914:12043:12517:12519:12740:13069:13148:13230:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: grade31_f85d6624340
X-Filterd-Recvd-Size: 2178
Message-ID: <1420246005.23591.7.camel@perches.com>
Subject: Re: [PATCH] GMAC: fix simple_return.cocci warnings
From: Joe Perches <joe@perches.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Roger Chen <roger.chen@rock-chips.com>, kbuild-all@01.org,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 02 Jan 2015 16:46:45 -0800
In-Reply-To: <20150103002526.GA15863@waimea.lkp.intel.com>
References: <201501030822.7cG5bXrm%fengguang.wu@intel.com>
	 <20150103002526.GA15863@waimea.lkp.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-01-03 at 08:25 +0800, kbuild test robot wrote:
> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> CC: Roger Chen <roger.chen@rock-chips.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  dwmac-rk.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> @@ -422,11 +422,7 @@ static int rk_gmac_init(struct platform_
>  	if (ret)
>  		return ret;
>  
> -	ret = gmac_clk_enable(bsp_priv, true);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return gmac_clk_enable(bsp_priv, true);

I think this change is not particularly better.

When the pattern is multiply repeated like:

{
	...
	foo = bar();
	if (foo)
		return foo;

	foo = baz();
	if (foo)
		return foo;

	foo = qux();
	if (foo)
		return foo;

	return 0;
}

I think it's better to not change the last
test in the sequence just to minimize overall
line count.