From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-4.5] libxl: Fix if{} nesting in
 do_pci_remove
Date: Mon, 5 Jan 2015 16:38:05 +0000
Message-ID: <1420475885.28863.70.camel@citrix.com>
References: <21674.46102.230057.321870@mariner.uk.xensource.com>
	<1420475676-19080-1-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1420475676-19080-1-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Sander Eikelenboom <linux@eikelenboom.it>, xen-devel@lists.xensource.com, Ian Jackson <iwj@mariner.uk.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-01-05 at 16:34 +0000, Ian Jackson wrote:
> From: Ian Jackson <iwj@mariner.uk.xensource.com>
> 
> do_pci_remove contained this:
> 
>     if (type == LIBXL_DOMAIN_TYPE_HVM) {
>        [stuff]
>     } else if (type != LIBXL_DOMAIN_TYPE_PV)
>         abort();
>     {
> 
> This is bizarre, and not correct.  The effect is that HVM guests end
> up running both the proper code and that intended for PV guests.  This
> causes (amongst other things) trouble when PCI devices are
> hot-unplugged from HVM guests.
> 
> This bug was introduced in abfb006f "tools/libxl: explicitly grant
> access to needed I/O-memory ranges".
> 
> This is clear candidate for Xen 4.5, being a bugfix to an important
> feature.
> 
> Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Tested-by: Robert Hu <robert.hu@intel.com>
> CC: Konrad Wilk <konrad.wilk@oracle.com>
> CC: Sander Eikelenboom <linux@eikelenboom.it>
> CC: George Dunlap <George.Dunlap@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>