Re: [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

[Ian Campbell <Ian.Campbell@citrix.com>]

On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote:
> The shell wrapper in xenstored.service does not handle XENSTORE_TRACE.
> 
> Create a separate wrapper script which is used in the sysv runlevel
> script and in systemd xenstored.service. It preserves existing
> behaviour by handling the XENSTORE_TRACE boolean. It also implements
> the handling of XENSTORED_ARGS=. This variable has to be added to
> sysconfig/xencommons.

Why don't we just drop XENSTORED_* in favour of XENSTORED_ARGS (with an
example in the sysconfig file of enabling tracing if you like)?

Going to a wrapper script just to make some fairly uncommon debugging
option marginally more convenient seems like overkill to me, plus
XENSTORED_ARGS would allow for passing other useful options to
xenstored.

> The wrapper uses exec unconditionally. This works because the
> systemd service file passes --no-fork, which has the desired effect
> that the binary launched by systemd becomes the final daemon
> process. The sysv script does not pass --no-fork, which causes
> xenstored to fork internally to return to the caller of the wrapper
> script.
> 
> The place of the wrapper is currently LIBEXEC_BIN, it has to be
> decided what the final location is supposed to be. IanJ wants it in
> "/etc".

If we go this route then I agree with Ian J. (/etc/xen/scripts, I
suppose).

Ian.