From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] tools/libxl: Use of init()/dispose() to avoid leaking libxl_dominfo.ssid_label Date: Tue, 6 Jan 2015 11:43:57 +0000 Message-ID: <1420544637.28863.151.camel@citrix.com> References: <1420467598-2660-1-git-send-email-andrew.cooper3@citrix.com> <20150105153316.GD11661@l.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150105153316.GD11661@l.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 2015-01-05 at 10:33 -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 05, 2015 at 02:19:58PM +0000, Andrew Cooper wrote: > > libxl_dominfo contains a ssid_label pointer which will have memory allocated > > for it in libxl_domain_info() if the hypervisor has CONFIG_XSM compiled. > > However, the lack of appropriate use of libxl_dominfo_{init,dispose}() will > > cause the label string to be leaked, even in success cases. > > > > This was discovered by XenServers Coverity scanning, and are issues not > > identified by upstream Coverity Scan. > > > > Signed-off-by: Andrew Cooper > > CC: Ian Campbell > > CC: Ian Jackson > > CC: Wei Liu > > CC: Konrad Rzeszutek Wilk > > > > --- > > > > Requesting a release-exception as suggested by IanJ. These are memory leaks > > which accumulate via the successful completion of libxl library functions (if > > XSM is enabled), which will undoubtedly cause issues for the likes of libvirt > > and xenopsd-libxl which use libxl in daemon processes. > > Release-Acked-by: Konrad Rzeszutek Wilk Somehow I don't seem to have the original in any folder, I probably fat fingered the D key at some point. Anyway, this looks good to me for 4.5: Acked-by: Ian Campbell Applied.