From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen: arm: correct off-by-one error in consider_modules Date: Tue, 06 Jan 2015 11:44:18 +0000 Message-ID: <1420544658.28863.152.camel@hellion.org.uk> References: <1419160733-31534-1-git-send-email-ijc@hellion.org.uk> <5497F849.3050806@linaro.org> <20150105161737.GH12923@l.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150105161737.GH12923@l.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Julien Grall , tim@xen.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-01-05 at 11:17 -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 22, 2014 at 11:54:01AM +0100, Julien Grall wrote: > > Hi Ian, > > > > On 21/12/2014 12:18, Ian Campbell wrote: > > >By iterating up to <= mi->nr_mods we are running off the end of the boot > > >modules, but more importantly it causes us to then skip the first FDT reserved > > >region, meaning we might clobber it. > > > > Oops. Good catch! > > > > OOI, how did you find it? > > > > >Signed-off-by: Ian Campbell > > > > Reviewed-by: Julien Grall > > > > >--- > > >For 4.5: I think this bug fix should go in, it fixes a real issue and is low > > >risk. > > Release-Acked-by: Konrad Rzeszutek Wilk Applied, thanks.