From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR Date: Wed, 07 Jan 2015 10:04:30 +0100 Message-ID: <1420621470.3893.6.camel@AMDC1943> References: <1420566151-7136-1-git-send-email-moon.linux@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:52703 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbbAGJEf (ORCPT ); Wed, 7 Jan 2015 04:04:35 -0500 In-reply-to: <1420566151-7136-1-git-send-email-moon.linux@yahoo.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Anand Moon Cc: Russell King , Kukjin Kim , Javier Martinez Canillas , Doug Anderson , Sachin Kamat , "Rafael J. Wysocki" , Vivek Gautam , Tushar Behera , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org On wto, 2015-01-06 at 23:12 +0530, Anand Moon wrote: > ARM Enable CONFIG_LOCKUP_DETECTOR to validaion of kernel locks s/validaion/validation/ This config item helps getting some useful information when lockup happens. If you want to validate locks then probably you want PROVE_LOCKING... but its overhead is larger. Anyway the overhead of LOCKUP_DETECTOR is small and multi_v7_defconfig has it enabled so I guess exynos may do it as well. Could you only fix up the commit msg? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > > Tested on Exynos5422 ODROID XU3 board. > > Signed-off-by: Anand Moon > --- > arch/arm/configs/exynos_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 5ef14de..ecd9987 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y > CONFIG_DEBUG_FS=y > CONFIG_MAGIC_SYSRQ=y > CONFIG_DEBUG_KERNEL=y > +CONFIG_LOCKUP_DETECTOR=y > CONFIG_DETECT_HUNG_TASK=y > CONFIG_DEBUG_RT_MUTEXES=y > CONFIG_DEBUG_SPINLOCK=y From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Wed, 07 Jan 2015 10:04:30 +0100 Subject: [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR In-Reply-To: <1420566151-7136-1-git-send-email-moon.linux@yahoo.com> References: <1420566151-7136-1-git-send-email-moon.linux@yahoo.com> Message-ID: <1420621470.3893.6.camel@AMDC1943> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On wto, 2015-01-06 at 23:12 +0530, Anand Moon wrote: > ARM Enable CONFIG_LOCKUP_DETECTOR to validaion of kernel locks s/validaion/validation/ This config item helps getting some useful information when lockup happens. If you want to validate locks then probably you want PROVE_LOCKING... but its overhead is larger. Anyway the overhead of LOCKUP_DETECTOR is small and multi_v7_defconfig has it enabled so I guess exynos may do it as well. Could you only fix up the commit msg? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > > Tested on Exynos5422 ODROID XU3 board. > > Signed-off-by: Anand Moon > --- > arch/arm/configs/exynos_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 5ef14de..ecd9987 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y > CONFIG_DEBUG_FS=y > CONFIG_MAGIC_SYSRQ=y > CONFIG_DEBUG_KERNEL=y > +CONFIG_LOCKUP_DETECTOR=y > CONFIG_DETECT_HUNG_TASK=y > CONFIG_DEBUG_RT_MUTEXES=y > CONFIG_DEBUG_SPINLOCK=y