From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: Xen-ringwatch generating many alerts
Date: Thu, 8 Jan 2015 10:25:04 +0000
Message-ID: <1420712704.19787.1.camel@citrix.com>
References: <1420696474396-5725675.post@n5.nabble.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1420696474396-5725675.post@n5.nabble.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vishalfaldu <vishal@servarica.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-01-07 at 22:54 -0700, vishalfaldu wrote:
> Hi ,
> 
> We have xen-ringwatch which is sending below alert frequently, Any one can
> help ?
> 
> Subject: Cron <root@DOM0> xen-ringwatch check -T3 --kick | logger -p
> daemon.crit -t RINGWATCH-ALERT
> To: root
> 
> 
> Traceback (most recent call last):
>   File "/usr/sbin/xen-ringwatch", line 593, in ?
>     watches.update()
>   File "/usr/sbin/xen-ringwatch", line 414, in update
>     entry = RingWatch.new(ring)
>   File "/usr/sbin/xen-ringwatch", line 357, in new
>     state = ring.read()
>   File "/usr/sbin/xen-ringwatch", line 136, in read
>     state = RingState.from_sysfs(self.path())
>   File "/usr/sbin/xen-ringwatch", line 223, in from_sysfs
>     req = cls.Req.from_sysfs(_req, size=nr_ents)
>   File "/usr/sbin/xen-ringwatch", line 240, in from_sysfs
>     raise Exception, "Malformed %s input: %s" % \
> NameError: global name 's' is not defined

It seems like there is a bug in the  error handling at line 240, repr(s)
ought to be repr(line), I think. If you fix that (and please do send a
patch if you do, see [0]) then I expect you'll get a more useful error
message.

Ian.

[0] http://wiki.xen.org/wiki/Submitting_Xen_Patches