All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Tim Deegan <tim@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xen.org, Junji Zhi <junji.xendev@gmail.com>
Subject: Re: Writable page tables questions
Date: Thu, 8 Jan 2015 11:30:31 +0000	[thread overview]
Message-ID: <1420716631.19787.27.camel@citrix.com> (raw)
In-Reply-To: <20150108111944.GA5043@deinos.phlegethon.org>

On Thu, 2015-01-08 at 12:19 +0100, Tim Deegan wrote:
> At 09:55 +0000 on 06 Jan (1420534536), Ian Campbell wrote:
> > The tlb flushes involved in the above are reasonably expensive, IIRC Xen
> > flip flopped a bit (years ago now) on whether it is worthwhile doing
> > this or not, which is why I'm not sure if it still does or not.
> 
> The current "writable pagetables" code for PV guests emulates the
> write and validates the resulting PTE.  If it passes validation, it
> updates it, without ever making the page actually writable to the
> guest itself.

Indeed, it seems like the mode I was on about was removed 9 years ago:

commit 228f081e08474febb96ee694f6d1b3d6d7465052
Author: kfraser@localhost.localdomain <kfraser@localhost.localdomain>
Date:   Fri Aug 11 16:07:22 2006 +0100

    [XEN] Remove batched writable pagetable logic.
    
    Benchmarks show it provides little or no benefit (except
    on synthetic benchmarks). Also it is complicated and
    likely to hinder efforts to reduce lockign granularity.
    
    Signed-off-by: Keir Fraser <keir@xensource.com>

$ git describe --contains 228f081e08474febb96ee694f6d1b3d6d7465052
3.0.3-branched~459

So in 3.0.3 apparently.

Ian.

      reply	other threads:[~2015-01-08 11:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 17:17 Writable page tables questions Junji Zhi
2015-01-05 17:28 ` Andrew Cooper
2015-01-06  9:55   ` Ian Campbell
2015-01-08 11:19     ` Tim Deegan
2015-01-08 11:30       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420716631.19787.27.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=junji.xendev@gmail.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.