From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 3/4] dt-uart: use ':' as separator
 between path and options
Date: Thu, 8 Jan 2015 12:29:59 +0000
Message-ID: <1420720199.19787.65.camel@citrix.com>
References: <1420718009.19787.44.camel@citrix.com>
	<1420718036-29651-3-git-send-email-ian.campbell@citrix.com>
	<54AE7777.8090204@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54AE7777.8090204@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-01-08 at 12:26 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 08/01/15 11:53, Ian Campbell wrote:
> > diff --git a/xen/drivers/char/dt-uart.c b/xen/drivers/char/dt-uart.c
> > index 04dbb97..b9a0956 100644
> > --- a/xen/drivers/char/dt-uart.c
> > +++ b/xen/drivers/char/dt-uart.c
> > @@ -31,7 +31,7 @@
> >   * doesn't start with '/', we assuming that it's an alias.
> >   * @options: UART speficic options (see in each UART driver)
> >   */
> 
> You forgot to modify the comment:
> 
> "Configure UART port with a string:
> path,options"

Oops, I'll fix on commit.

> With this change:
> 
> Reviewed-by: Julien Grall <julien.grall@linaro.org>

Thanks,
Ian.

> 
> Regards,
>