From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Y9G6l-0001fH-Mf
	for mharc-grub-devel@gnu.org; Thu, 08 Jan 2015 11:38:51 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Y9G6f-0001a9-RT
	for grub-devel@gnu.org; Thu, 08 Jan 2015 11:38:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Y9G6b-0000YW-HP
	for grub-devel@gnu.org; Thu, 08 Jan 2015 11:38:45 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:51021)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Y9G6b-0000YP-D0
	for grub-devel@gnu.org; Thu, 08 Jan 2015 11:38:41 -0500
X-IronPort-AV: E=Sophos;i="5.07,723,1413244800"; d="scan'208";a="213433790"
Message-ID: <1420735118.19787.111.camel@citrix.com>
Subject: Re: [PATCH 0/5]arm64: Add multiboot support (via fdt) for Xen boot
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Fu Wei <fu.wei@linaro.org>
Date: Thu, 8 Jan 2015 16:38:38 +0000
In-Reply-To: <54931519.50905@linaro.org>
References: <54931519.50905@linaro.org>
Organization: Citrix Systems, Inc.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 66.165.176.63
Cc: Roy Franz <roy.franz@linaro.org>, grub-devel@gnu.org,
	linaro-uefi <linaro-uefi@lists.linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>, Jon Masters <jcm@redhat.com>
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jan 2015 16:38:50 -0000

On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

I've tested the code at
git://git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
which I believe is the same as this posting on an AMD Seattle system
with a 40_custom containing:

        menuentry 'Baremetal' {
        	insmod gzio
        	insmod part_msdos
        	insmod ext2
        	set root='hd0,msdos2'
        	search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
        	linux /boot/vmlinuz console=ttyAMA0,115200n8 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }
        menuentry 'Xen' {
        	insmod gzio
        	insmod part_msdos
        	insmod ext2
        	set root='hd0,msdos2'
        	search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
        	multiboot /boot/xen no-bootscrub console=dtuart conswitch=x dtuart=/smb/serial@e1010000 noreboot sync_console dom0_mem=256M dom0_max_vcpus=1
        	module /boot/vmlinuz-xen console=hvc0 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }

(my system is too confused for 10_linux or 20_linux_xen right now, but I
believe this is representative of what they would emit)

The result was that I could boot both Baremetal and Xen via grub. So:

Tested-by: Ian Campbell <ian.campbell@citrix.com>

I've not looked at the code (although I did review several older
iterations), would it be useful to the grub maintainers for me to do so?

Ian.