From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andy Grover <agrover@redhat.com>
Cc: linux-scsi@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 3/3] scsi: Remove scsi_ioctl.h
Date: Thu, 08 Jan 2015 12:35:02 -0800 [thread overview]
Message-ID: <1420749302.5830.31.camel@HansenPartnership.com> (raw)
In-Reply-To: <1420746479-25949-4-git-send-email-agrover@redhat.com>
On Thu, 2015-01-08 at 11:47 -0800, Andy Grover wrote:
> Now that we have uapi/scsi/scsi.h, that is the logical place for SCSI ioctl
> definitions to go. The kernel-specific stuff that remains is so little that
> it can be folded into scsi/scsi.h, and scsi_ioctl.h removed.
>
> Remove all scsi_ioctl.h #includes since they all also include scsi/scsi.h,
> except for ide-floppy_ioctl.c where we just replace it with including
> scsi/scsi.h.
What's the transition plan for userspace? If you look at glibc
currently, it supplies both scsi.h and scsi_ioctl.h. If we're
persuading the glibc folks to go with our versions from uapi, I think
removing a file which is an effective compile breaker for userspace is a
really bad idea. Duplicating scsi_ioctl.h definitions in scsi.h would
also cause them problems.
James
next prev parent reply other threads:[~2015-01-08 20:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 19:47 [PATCH 0/3] Add uapi/scsi/scsi.h Andy Grover
2015-01-08 19:47 ` [PATCH 1/3] scsi: add WRITE_VERIFY_16 to scsi.h Andy Grover
2015-01-08 19:47 ` [PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h Andy Grover
2015-01-09 10:14 ` Christoph Hellwig
2015-01-09 15:27 ` James Bottomley
2015-01-09 15:46 ` Christoph Hellwig
2015-01-09 15:50 ` James Bottomley
2015-01-09 16:01 ` Christoph Hellwig
2015-01-09 16:33 ` James Bottomley
2015-01-09 17:11 ` Christoph Hellwig
2015-01-09 17:44 ` James Bottomley
2015-01-08 19:47 ` [PATCH 3/3] scsi: Remove scsi_ioctl.h Andy Grover
2015-01-08 20:35 ` James Bottomley [this message]
2015-01-08 21:26 ` Andy Grover
2015-01-09 9:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420749302.5830.31.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=agrover@redhat.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.