From: Joe Perches <joe@perches.com>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch wrong error message
Date: Fri, 09 Jan 2015 05:31:13 -0800 [thread overview]
Message-ID: <1420810273.32628.2.camel@perches.com> (raw)
In-Reply-To: <CAEnQRZDKhgSV=+P_M9aJP-+8DftxVmjgHgAR7OAxFUku6RHsHw@mail.gmail.com>
On Fri, 2015-01-09 at 13:57 +0200, Daniel Baluta wrote:
> Hi Joe,
>
> Running ./scripts/checkpatch on the attached [1] patch i get the
> following error:
>
> ERROR: Please use 12 or more chars for the git commit ID like: 'commit
> 01234567890ab ("commit description")'
> #6:
> After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
checkpatch uses the same message for multiple forms.
There were some patches around to make this clearer.
https://lkml.org/lkml/2014/10/20/630
Your commit message does not have quotes around the text.
It should be:
After commit <2b49ccbdd54 ("PM: Kconfig: Set ...")
next prev parent reply other threads:[~2015-01-09 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 11:57 checkpatch wrong error message Daniel Baluta
2015-01-09 13:31 ` Joe Perches [this message]
2015-01-09 13:37 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420810273.32628.2.camel@perches.com \
--to=joe@perches.com \
--cc=daniel.baluta@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.