From: Joe Perches <joe@perches.com>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components
Date: Sat, 10 Jan 2015 14:35:38 -0800 [thread overview]
Message-ID: <1420929338.16787.6.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1501102203380.2303@localhost.localdomain>
On Sat, 2015-01-10 at 22:21 +0000, Scot Doyle wrote:
> Call printk twice since this log entry has two lines and headings.
>
> [ 0.009285] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
> Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4
>
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> ---
> arch/x86/kernel/cpu/common.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index c604965..76f253f 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -496,12 +496,12 @@ void cpu_detect_tlb(struct cpuinfo_x86 *c)
> if (this_cpu->c_detect_tlb)
> this_cpu->c_detect_tlb(c);
>
> - printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n"
> - "Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
> + printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n",
> tlb_lli_4k[ENTRIES], tlb_lli_2m[ENTRIES],
> - tlb_lli_4m[ENTRIES], tlb_lld_4k[ENTRIES],
> - tlb_lld_2m[ENTRIES], tlb_lld_4m[ENTRIES],
> - tlb_lld_1g[ENTRIES]);
> + tlb_lli_4m[ENTRIES]);
> + printk(KERN_INFO "Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
> + tlb_lld_4k[ENTRIES], tlb_lld_2m[ENTRIES],
> + tlb_lld_4m[ENTRIES], tlb_lld_1g[ENTRIES]);
> }
Check your dmesg version
https://lkml.org/lkml/2014/11/1/67
https://lkml.org/lkml/2014/11/2/1
next prev parent reply other threads:[~2015-01-10 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 22:21 [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components Scot Doyle
2015-01-10 22:35 ` Joe Perches [this message]
2015-01-10 23:57 ` Scot Doyle
2015-01-11 0:07 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420929338.16787.6.camel@perches.com \
--to=joe@perches.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml14@scotdoyle.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.