From: Joe Perches <joe@perches.com>
To: Christoph Jaeger <cj@linux.com>, Alan <alan@linux.intel.com>
Cc: davem@davemloft.net, willemb@google.com, edumazet@google.com,
dborkman@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] packet: bail out of packet_snd() if L2 header creation fails
Date: Sun, 11 Jan 2015 10:52:25 -0800 [thread overview]
Message-ID: <1421002345.9233.1.camel@perches.com> (raw)
In-Reply-To: <1420999276-28225-1-git-send-email-cj@linux.com>
On Sun, 2015-01-11 at 13:01 -0500, Christoph Jaeger wrote:
> Due to a misplaced parenthesis, the expression
>
> (unlikely(offset) < 0),
>
> which expands to
>
> (__builtin_expect(!!(offset), 0) < 0),
Here's another one:
drivers/platform/goldfish/goldfish_pipe.c:285: if (unlikely(bufflen) == 0)
next prev parent reply other threads:[~2015-01-11 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 18:01 [PATCH net] packet: bail out of packet_snd() if L2 header creation fails Christoph Jaeger
2015-01-11 18:35 ` Eric Dumazet
2015-01-11 18:49 ` Willem de Bruijn
2015-01-11 18:52 ` Joe Perches [this message]
2015-01-11 19:34 ` Christoph Jaeger
2015-01-11 19:49 ` [PATCH] checkpatch: Add likely/unlikely comparison misuse test Joe Perches
2015-01-11 21:38 ` [PATCH net] packet: bail out of packet_snd() if L2 header creation fails Daniel Borkmann
2015-01-12 2:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421002345.9233.1.camel@perches.com \
--to=joe@perches.com \
--cc=alan@linux.intel.com \
--cc=cj@linux.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.