From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: xen-ringwatch issues Date: Mon, 12 Jan 2015 09:49:39 +0000 Message-ID: <1421056179.26317.6.camel@citrix.com> References: <1420798214.21186.10.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: moftah moftah Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-01-09 at 17:00 -0500, moftah moftah wrote: > Hi Ian, > > > OK, I have followed your suggestions and created a new patch Thanks, please submit it in the form describe in the wiki page http://wiki.xen.org/wiki/Submitting_Xen_Patches which I referenced before. In particular, a Signed-off-by is a strict requirement for licensing reasons, to indicate that you have read the DCO (which is at http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch ). Please also provide a suitable changelog entry and use a unified diff (diff -u). I think rather than "[-]*" the right addition would be -? (i.e. a single optional negative sign), unless Python's re syntax is lots different to what I expect. > this new patch does fix the issue fully for the negative numbers > > I didnt run the patch on 64bit OS since xenserver has 32bit Dom0 These fields are unsigned int, .i.e. always 32-bits. So I think your "if self.conf < 0: self.cons = 4294967296 + self.cons" etc will work. The Internet also suggests "ctypes.c_uint32(i).value", dunno if that is better. In any case writing 4294967296 as 2**32 would be slightly clearer. Ian.