From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH resend] libxl,
 hotplug/Linux: default to phy backend for raw format file, take 2
Date: Mon, 12 Jan 2015 10:18:54 +0000
Message-ID: <1421057934.26317.14.camel@citrix.com>
References: <1420724813-17920-1-git-send-email-wei.liu2@citrix.com>
	<54AE952D.70304@m2r.biz> <20150109144233.GB32179@zion.uk.xensource.com>
	<1420825136.13270.45.camel@Abyss.station> <54B3909D.1040102@m2r.biz>
	<1421055106.26317.0.camel@citrix.com> <54B3963F.9070205@m2r.biz>
	<1421057194.26317.13.camel@citrix.com> <54B39F39.1010408@m2r.biz>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54B39F39.1010408@m2r.biz>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-01-12 at 11:17 +0100, Fabio Fantoni wrote:
> Il 12/01/2015 11:06, Ian Campbell ha scritto:
> > On Mon, 2015-01-12 at 10:39 +0100, Fabio Fantoni wrote:
> >> Il 12/01/2015 10:31, Ian Campbell ha scritto:
> >>> On Mon, 2015-01-12 at 10:15 +0100, Fabio Fantoni wrote:
> >>>> In the meantime, I saw this:
> >>>> http://lists.xen.org/archives/html/xen-users/2015-01/msg00047.html
> >>>> Based on the post above seems that phy will have important risk of data
> >>>> loss if I understand good, from Ian Campbell post:
> >>>>> xl also uses qdisk for raw disk images instead of loop+blkback which
> >>>>> xend used, because there are concerns that the loop driver can lead to
> >>>>> data loss (by not implementing direct i/o the underlying device, and/or
> >>>>> not handling flushes correct, my memory is a bit fuzzy).
> >>> Stefano already corrected me on this in this very thread.
> >>>
> >>> Ian.
> >>>
> >> Thanks for your reply.
> >> I saw other posts about and if I understand good when O_DIRECT patches
> >> will be in upstream loop driver the data loss risk will be solved, right?
> > Stefano says that O_DIRECT is not needed, only correct barrier semantics
> > are and he believes those are correctly implemented.
> 
> I not understand if manual changes and/or settings are needed, about 
> this I mean:
> > only correct barrier semantics are and he believes those are correctly implemented
> If yes what exactly?

If Stefano is correct then it should all just work, no manual steps
needed (if manual steps were needed we wouldn't be taking this patch).

Ian.