From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c Date: Mon, 12 Jan 2015 13:29:27 +0000 Message-ID: <1421069367.31978.21.camel@linux.intel.com> References: <1420950664-18875-1-git-send-email-xerofoify@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E3B106E455 for ; Mon, 12 Jan 2015 05:29:41 -0800 (PST) In-Reply-To: <1420950664-18875-1-git-send-email-xerofoify@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicholas Krause Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@redhat.com, treding@nvidia.com List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAyMDE1LTAxLTEwIGF0IDIzOjMxIC0wNTAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6 Cj4gQ2hhbmdlcyB2YXJpb3VzIGNhbGxzIGluIHRoZSBmdW5jdGlvbnMsc2VuZF9wa2dfcHJlcGFy ZSBhbmQgc2VuZF9wa2dfZG9uZQo+IGZvciBtZGVsYXkgdG8gbXNsZWVwLiBUaGVzZSBjaGFuZ2Vz IGFyZSBuZWVkZWQgZHVlIHRvIHVzZSB3b3JraW5nIHdpdGgKPiB2YXJpb3VzIHNsZWVwIG1vZGVz IHN1cHBvcnRlZCBieSB0aGlzIGhhcmR3YXJlIGFuZCB0aHVzIG5lZWRpbmcgdG8gc2xlZXAKPiBm b3IgYSBzbWFsbCBkdXJhdGlvbiBpbnN0ZWFkIG9mIHVzaW5nIHRoZSByZXNwZWN0ZnVsIGRlbGF5 IGZ1bmN0aW9uIGR1ZQo+IHRvIHRoZSBuZWVkIHRvIHNsZWVwIHJhdGhlciB0aGVuIGJ1c3kgbG9v cCB0aGUgQ1BVKHMpIGFuZCB3YXN0ZSBDUFUgY3ljbGVzCj4gb24gdGhlIHN5c3RlbSB0aGF0IGNv dWxkIGJlIHVzZWQgdG8gaGFuZGxlIG90aGVyIHRhc2tzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE5p Y2hvbGFzIEtyYXVzZSA8eGVyb2ZvaWZ5QGdtYWlsLmNvbT4KCk5BSwoKTGlrZSBldmVyeSBvdGhl ciBUT0RPIHlvdSd2ZSBiZWVuIG11Y2tpbmcgd2l0aCBhdCByYW5kb20gdGhpcyBvbmUgaXMKdGhl cmUgZm9yIGEgcmVhc29uLgoKV2UgY2FuJ3Qgc2xlZXAgYXQgdGhpcyBwb2ludC4KCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753069AbbALN3o (ORCPT ); Mon, 12 Jan 2015 08:29:44 -0500 Received: from mga09.intel.com ([134.134.136.24]:43808 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbbALN3m (ORCPT ); Mon, 12 Jan 2015 08:29:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,744,1413270000"; d="scan'208";a="649813365" Message-ID: <1421069367.31978.21.camel@linux.intel.com> Subject: Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c From: Alan Cox To: Nicholas Krause Cc: airlied@linux.ie, airlied@redhat.com, damien.lespiau@intel.com, treding@nvidia.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Mon, 12 Jan 2015 13:29:27 +0000 In-Reply-To: <1420950664-18875-1-git-send-email-xerofoify@gmail.com> References: <1420950664-18875-1-git-send-email-xerofoify@gmail.com> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 (3.12.9-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote: > Changes various calls in the functions,send_pkg_prepare and send_pkg_done > for mdelay to msleep. These changes are needed due to use working with > various sleep modes supported by this hardware and thus needing to sleep > for a small duration instead of using the respectful delay function due > to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles > on the system that could be used to handle other tasks. > > Signed-off-by: Nicholas Krause NAK Like every other TODO you've been mucking with at random this one is there for a reason. We can't sleep at this point.