From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c Date: Mon, 12 Jan 2015 16:14:49 +0000 Message-ID: <1421079289.31978.34.camel@linux.intel.com> References: <1420950664-18875-1-git-send-email-xerofoify@gmail.com> <1421069367.31978.21.camel@linux.intel.com> <20150112161233.GC16118@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 889826E510 for ; Mon, 12 Jan 2015 08:15:40 -0800 (PST) In-Reply-To: <20150112161233.GC16118@ulmo.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Nicholas Krause , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAyMDE1LTAxLTEyIGF0IDE3OjEyICswMTAwLCBUaGllcnJ5IFJlZGluZyB3cm90ZToK PiBPbiBNb24sIEphbiAxMiwgMjAxNSBhdCAwMToyOToyN1BNICswMDAwLCBBbGFuIENveCB3cm90 ZToKPiA+IE9uIFNhdCwgMjAxNS0wMS0xMCBhdCAyMzozMSAtMDUwMCwgTmljaG9sYXMgS3JhdXNl IHdyb3RlOgo+ID4gPiBDaGFuZ2VzIHZhcmlvdXMgY2FsbHMgaW4gdGhlIGZ1bmN0aW9ucyxzZW5k X3BrZ19wcmVwYXJlIGFuZCBzZW5kX3BrZ19kb25lCj4gPiA+IGZvciBtZGVsYXkgdG8gbXNsZWVw LiBUaGVzZSBjaGFuZ2VzIGFyZSBuZWVkZWQgZHVlIHRvIHVzZSB3b3JraW5nIHdpdGgKPiA+ID4g dmFyaW91cyBzbGVlcCBtb2RlcyBzdXBwb3J0ZWQgYnkgdGhpcyBoYXJkd2FyZSBhbmQgdGh1cyBu ZWVkaW5nIHRvIHNsZWVwCj4gPiA+IGZvciBhIHNtYWxsIGR1cmF0aW9uIGluc3RlYWQgb2YgdXNp bmcgdGhlIHJlc3BlY3RmdWwgZGVsYXkgZnVuY3Rpb24gZHVlCj4gPiA+IHRvIHRoZSBuZWVkIHRv IHNsZWVwIHJhdGhlciB0aGVuIGJ1c3kgbG9vcCB0aGUgQ1BVKHMpIGFuZCB3YXN0ZSBDUFUgY3lj bGVzCj4gPiA+IG9uIHRoZSBzeXN0ZW0gdGhhdCBjb3VsZCBiZSB1c2VkIHRvIGhhbmRsZSBvdGhl ciB0YXNrcy4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE5pY2hvbGFzIEtyYXVzZSA8eGVy b2ZvaWZ5QGdtYWlsLmNvbT4KPiA+IAo+ID4gTkFLCj4gPiAKPiA+IExpa2UgZXZlcnkgb3RoZXIg VE9ETyB5b3UndmUgYmVlbiBtdWNraW5nIHdpdGggYXQgcmFuZG9tIHRoaXMgb25lIGlzCj4gPiB0 aGVyZSBmb3IgYSByZWFzb24uCj4gPiAKPiA+IFdlIGNhbid0IHNsZWVwIGF0IHRoaXMgcG9pbnQu Cj4gCj4gRnJvbSBhIHF1aWNrIGxvb2sgaXQgc2VlbXMgbGlrZSB0aGUgb25seSByZWFzb24gd2h5 IHdlIGNhbid0IHNsZWVwIGlzCj4gYmVjYXVzZSBzZW5kZXItPmxvY2sgaXMgYSBzcGlubG9jay4g QnV0IGl0IHdvdWxkIHNlZW0gdGhhdCBpdCBjb3VsZAo+IHNpbXBseSBiZSBhIG11dGV4LCBpbiB3 aGljaCBjYXNlIHRoZSBkZWxheXMgY291bGQgYmVjb21lIHNsZWVwcy4KPiAKPiBEbyB5b3UgaGFw cGVuIHRvIHJlbWVtYmVyIGlmIHRoZXJlIHdlcmUgc3BlY2lmaWMgcmVhc29ucyB0byBtYWtlIHRo aXMgYQo+IHNwaW5sb2NrIHJhdGhlciB0aGFuIGEgbXV0ZXg/CgpJIGRvbid0IHJlbWVtYmVyIHRo ZSBmdWxsIGRldGFpbHMgYW5kIHNpbmNlIEkgZG9uJ3QgY3VycmVudGx5IGhhdmUgYQp0ZXN0IHBs YXRmb3JtIGZvciBpdCwgYW5kIGl0cyBvYnNvbGV0ZSBJIGRvbid0IHdhbnQgdG8gdG91Y2ggaXQu CgpJZiBzb21lb25lIGVsc2UgZG9lcyBmaW5lLCBidXQgdGhleSBuZWVkIHRvIHZlcmlmeSBpdCBv biByZWFsIGhhcmR3YXJlLgoKQWxhbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbbALQP5 (ORCPT ); Mon, 12 Jan 2015 11:15:57 -0500 Received: from mga09.intel.com ([134.134.136.24]:61079 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753778AbbALQPj (ORCPT ); Mon, 12 Jan 2015 11:15:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,744,1413270000"; d="scan'208";a="649879368" Message-ID: <1421079289.31978.34.camel@linux.intel.com> Subject: Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c From: Alan Cox To: Thierry Reding Cc: Nicholas Krause , airlied@linux.ie, airlied@redhat.com, damien.lespiau@intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Mon, 12 Jan 2015 16:14:49 +0000 In-Reply-To: <20150112161233.GC16118@ulmo.nvidia.com> References: <1420950664-18875-1-git-send-email-xerofoify@gmail.com> <1421069367.31978.21.camel@linux.intel.com> <20150112161233.GC16118@ulmo.nvidia.com> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 (3.12.9-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-01-12 at 17:12 +0100, Thierry Reding wrote: > On Mon, Jan 12, 2015 at 01:29:27PM +0000, Alan Cox wrote: > > On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote: > > > Changes various calls in the functions,send_pkg_prepare and send_pkg_done > > > for mdelay to msleep. These changes are needed due to use working with > > > various sleep modes supported by this hardware and thus needing to sleep > > > for a small duration instead of using the respectful delay function due > > > to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles > > > on the system that could be used to handle other tasks. > > > > > > Signed-off-by: Nicholas Krause > > > > NAK > > > > Like every other TODO you've been mucking with at random this one is > > there for a reason. > > > > We can't sleep at this point. > > From a quick look it seems like the only reason why we can't sleep is > because sender->lock is a spinlock. But it would seem that it could > simply be a mutex, in which case the delays could become sleeps. > > Do you happen to remember if there were specific reasons to make this a > spinlock rather than a mutex? I don't remember the full details and since I don't currently have a test platform for it, and its obsolete I don't want to touch it. If someone else does fine, but they need to verify it on real hardware. Alan