From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/misc: Cleanup makefile Date: Mon, 12 Jan 2015 16:43:25 +0000 Message-ID: <1421081005.28776.7.camel@citrix.com> References: <1420724062-16728-1-git-send-email-andrew.cooper3@citrix.com> <20150109145301.GC32179@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150109145301.GC32179@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Andrew Cooper , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, 2015-01-09 at 14:53 +0000, Wei Liu wrote: > On Thu, Jan 08, 2015 at 01:34:22PM +0000, Andrew Cooper wrote: > > The existing makefile was awkward with needing to express conditional > > inclusion for both the build and install rules, and contained both split and > > unsplit long lines. > > > > The INSTALL_* rules now contain the conditional inclusion information, while > > the TARGET_* rules generate the build list from the complete install list, > > less the minority of scripts which simply need copying into place. Comments > > are introduces to aid clarity. > > > > In addition, collect the CFLAGS expressions, remove the unreferenced and empty > > HDRS list, and restrict the libxc internals build fix to the offending > > binaries. > > > > No functional change as a result of this patch, but it is rather more simple > > to add or remove utilities. > > > > Signed-off-by: Andrew Cooper > > CC: Ian Campbell > > CC: Ian Jackson > > CC: Wei Liu > > This looks correct to me. > > Acked-by: Wei Liu Applied, thanks.