From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 08/14] xen-netback: use foreign page
 information from the pages themselves
Date: Mon, 12 Jan 2015 17:20:24 +0000
Message-ID: <1421083224.28776.25.camel@citrix.com>
References: <1421077417-7162-1-git-send-email-david.vrabel@citrix.com>
	<1421077417-7162-9-git-send-email-david.vrabel@citrix.com>
	<1421081764.28776.10.camel@citrix.com> <54B40178.6000802@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YAig2-0006dy-Ua
	for xen-devel@lists.xenproject.org; Mon, 12 Jan 2015 17:21:19 +0000
In-Reply-To: <54B40178.6000802@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Jenny Herbert <jennifer.herbert@citrix.com>, Jenny Herbert <jenny.herbert@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-01-12 at 17:16 +0000, David Vrabel wrote:
> On 12/01/15 16:56, Ian Campbell wrote:
> > On Mon, 2015-01-12 at 15:43 +0000, David Vrabel wrote:
> >> From: Jenny Herbert <jenny.herbert@citrix.com>
> >>
> >> Use the foreign page flag in netback to get the domid and grant ref
> >> needed for the grant copy.  This signficiantly simplifies the netback
> >> code and makes netback work with foreign pages from other backends
> >> (e.g., blkback).
> >>
> >> This allows blkback to use iSCSI disks provided by domUs running on
> >> the same host.
> >>
> >> Signed-off-by: Jenny Herbert <jennifer.herbert@citrix.com>
> >> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> > 
> > I acked v1, has this version changed significantly enough to warrant a
> > re-review? (Does seem so on first glance)
> 
> The important change is:
> 
> v1:
> 
> +		if (PageForeign(page)) {
> +			get_page_grant_ref(page, &copy_gop->source.domid,
> +					   &copy_gop->source.u.ref);
> 
> v2:
> 
> +		struct xen_page_foreign *foreign;
> ...
> +		foreign = xen_page_foreign(page);
> +		if (foreign) {
> +			copy_gop->source.domid = foreign->domid;
> +			copy_gop->source.u.ref = foreign->gref;

Thanks, the ack can stand then.