From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 05/19] libxl: introduce vNUMA types Date: Mon, 12 Jan 2015 17:24:52 +0000 Message-ID: <1421083492.28776.27.camel@citrix.com> References: <1417448023-27311-1-git-send-email-wei.liu2@citrix.com> <1417448023-27311-6-git-send-email-wei.liu2@citrix.com> <1421083044.28776.24.camel@citrix.com> <20150112172101.GH4226@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150112172101.GH4226@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ufimtseva@gmail.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-01-12 at 17:21 +0000, Wei Liu wrote: > On Mon, Jan 12, 2015 at 05:17:24PM +0000, Ian Campbell wrote: > > On Mon, 2014-12-01 at 15:33 +0000, Wei Liu wrote: > > > > Looking ahead a few patches I see a disturbing trend to include little > > or no commit message in this series. I also see no overview of what the > > design for vnuma at the libxl level is going to look like, just a bunch > > of moving parts in isolation, which are rather hard to review. > > > > Please can you flesh out the descriptions of these patches, and maybe > > take a look at the series structure. e.g. I'm not sure why the next > > patch "libxl: add vmemrange to libxl__domain_build_state" needs to be > > alone, instead of adding the struct field in the patch which adds > > support for the field. > > > > I will provide more information and resend. Thanks.