From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse network device options Date: Mon, 12 Jan 2015 17:58:55 +0000 Message-ID: <1421085535.28776.45.camel@citrix.com> References: <1413927381-21549-1-git-send-email-alecsandra.sandulescu@gmail.com> <1413977758.19198.12.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YAjIg-00034a-Jr for xen-devel@lists.xenproject.org; Mon, 12 Jan 2015 18:01:14 +0000 In-Reply-To: <1413977758.19198.12.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Alexandra Sandulescu Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com, konrad@darnok.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-10-22 at 12:35 +0100, Ian Campbell wrote: > On Wed, 2014-10-22 at 00:36 +0300, Alexandra Sandulescu wrote: > > This patch removes duplicate code in /tools/libxl/xl_cmdimpl.c by > > adding parse_nic_config function. This function parses configuration > > data and adds the information into libxl_device_nic struct. It is > > called in both main_networkattach and parse_config_data functions > > to replace duplicate code. > > > > Signed-off-by: Alexandra Sandulescu > > Acked-by: Wei Liu > > This looks good to me, thanks. I've now applied this since the freeze is over. Ian.