From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 01/10] xen/arm: Implement hip04-d01 platform
Date: Tue, 13 Jan 2015 11:58:03 +0000
Message-ID: <1421150283.19103.39.camel@citrix.com>
References: <1415009522-6344-1-git-send-email-frediano.ziglio@huawei.com>
	<1415009522-6344-2-git-send-email-frediano.ziglio@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1415009522-6344-2-git-send-email-frediano.ziglio@huawei.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Frediano Ziglio <frediano.ziglio@huawei.com>
Cc: Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@linaro.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, zoltan.kiss@huawei.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-11-03 at 10:11 +0000, Frediano Ziglio wrote:
> Add this new platform to Xen.
> This platform require specific code to initialize CPUs.

What is the "bootwrapper"? Are you running this on real silicon or on an
emulator? Can the platform be made to do PSCI instead?

> +    np_fab = dt_find_compatible_node(NULL, NULL, "hisilicon,hip04-fabric");

Please add a reference to the DT bindings document for these values.

linux/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
seems related but doesn't talk about most of these fields.

> +    msg = "hisilicon,hip04-fabric missing in DT\n";
> +    if ( !np_fab )
> +        goto err;
> +
> +    msg = "failed to get bootwrapper-phys\n";
> +    if ( !dt_property_read_u32(np, "bootwrapper-phys",
> +                               &hip04_boot.bootwrapper_phys) )
> +        goto err;
> +
> +    msg = "failed to get bootwrapper-size\n";
> +    if ( !dt_property_read_u32(np, "bootwrapper-size",
> +                               &hip04_boot.bootwrapper_size) )
> +        goto err;
> +
> +    msg = "failed to get bootwrapper-magic\n";
> +    if ( !dt_property_read_u32(np, "bootwrapper-magic",
> +                               &hip04_boot.bootwrapper_magic) )
> +        goto err;
> +
> +    msg = "failed to get relocation-entry\n";
> +    if ( !dt_property_read_u32(np, "relocation-entry",
> +                               &hip04_boot.relocation_entry) )
> +        goto err;
> +
> +    msg = "failed to get relocation-size\n";
> +    if ( !dt_property_read_u32(np, "relocation-size",
> +                 &hip04_boot.relocation_size) )
> +        goto err;