From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libxl: provide xenlight.pc
Date: Tue, 13 Jan 2015 12:11:29 +0000
Message-ID: <1421151089.19103.43.camel@citrix.com>
References: <1420813938-23836-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1420813938-23836-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: jfehlig@suse.com, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-01-09 at 14:32 +0000, Wei Liu wrote:
> A pkg-config file for libxl. It also contains two variables
> (xenfirmwaredir and libexec_bin) so that tools that are very keen on
> knowing the locations of Xen binaries (say, libvirt) can use them to
> determine the location of the binaries.
> 
> Please rerun autogen.sh after applying this patch.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>

This seems like a reasonable thing to provide and the manner which you
do so seems sane. I've not actually read any pkg-config specs to check
the content, but it looks plausible:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

We ought to consider if there are any other libraries we should do this
for, I think non-stable API ones like libxenctrl/guest should be
explicitly excluded.

Ian.