From: Ian Campbell <Ian.Campbell@citrix.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Andrew Jones <drjones@redhat.com>,
Julien Grall <julien.grall@linaro.org>,
Keir Fraser <keir@xen.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Olaf Hering <olaf@aepfle.de>, Tim Deegan <tim@xen.org>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v5 6/9] libxl: add libxl__domain_soft_reset_destroy()
Date: Tue, 13 Jan 2015 13:58:30 +0000 [thread overview]
Message-ID: <1421157510.19103.64.camel@citrix.com> (raw)
In-Reply-To: <1418305541-5135-7-git-send-email-vkuznets@redhat.com>
On Thu, 2014-12-11 at 14:45 +0100, Vitaly Kuznetsov wrote:
> New libxl__domain_soft_reset_destroy() is an internal-only
> version of libxl_domain_destroy() which follows the same domain
> destroy path with the only difference: xc_domain_destroy() is
> being avoided so the domain is not actually being destroyed.
Rather than duplicating the bulk of libxl_domain_destroy, please make
this libxl__domain_destroy taking a flag and turn libxl_domain_destroy
into a thin wrapper around the new internal version.
> Add soft_reset flag to libxl__domain_destroy_state structure
> to support the change.
>
> The original libxl_domain_destroy() function could be easily
> modified to support new flag but I'm trying to avoid that as
> it is part of public API.
There are mechanisms which could be used here to rev the API if it was
desirable to expose this flag to the calling toolstack for some reason,
e.g. checkout the uses of LIBXL_API_VERSION in libxl.h.
Ian.
next prev parent reply other threads:[~2015-01-13 13:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 13:45 [PATCH v5 0/9] toolstack-based approach to pvhvm guest kexec Vitaly Kuznetsov
2014-12-11 13:45 ` [PATCH v5 1/9] xen: introduce DOMDYING_locked state Vitaly Kuznetsov
2014-12-18 13:23 ` Jan Beulich
2014-12-11 13:45 ` [PATCH v5 2/9] xen: introduce SHUTDOWN_soft_reset shutdown reason Vitaly Kuznetsov
2014-12-18 13:28 ` Jan Beulich
2015-01-13 12:20 ` Ian Campbell
2014-12-11 13:45 ` [PATCH v5 3/9] libxl: support " Vitaly Kuznetsov
2015-01-13 12:22 ` Ian Campbell
2015-01-13 12:23 ` Ian Campbell
2014-12-11 13:45 ` [PATCH v5 4/9] xen: introduce XEN_DOMCTL_devour Vitaly Kuznetsov
2014-12-18 13:57 ` Jan Beulich
2015-01-13 12:26 ` Ian Campbell
2015-01-13 13:53 ` Ian Campbell
2015-01-13 14:48 ` Tim Deegan
2015-01-13 16:17 ` Vitaly Kuznetsov
2015-01-13 16:24 ` Jan Beulich
2015-01-13 16:45 ` Vitaly Kuznetsov
2015-01-13 16:56 ` Jan Beulich
2015-01-13 16:41 ` Ian Campbell
2014-12-11 13:45 ` [PATCH v5 5/9] libxc: support XEN_DOMCTL_devour Vitaly Kuznetsov
2014-12-11 13:45 ` [PATCH v5 6/9] libxl: add libxl__domain_soft_reset_destroy() Vitaly Kuznetsov
2015-01-13 13:58 ` Ian Campbell [this message]
2014-12-11 13:45 ` [PATCH v5 7/9] libxc: introduce soft reset for HVM domains Vitaly Kuznetsov
2015-01-13 14:08 ` Ian Campbell
2014-12-11 13:45 ` [PATCH v5 8/9] libxl: soft reset support Vitaly Kuznetsov
2015-01-13 14:21 ` Ian Campbell
2014-12-11 13:45 ` [PATCH v5 9/9] xsm: add XEN_DOMCTL_devour support Vitaly Kuznetsov
2014-12-18 13:59 ` Jan Beulich
2015-01-05 12:46 ` [PATCH v5 0/9] toolstack-based approach to pvhvm guest kexec Wei Liu
2015-01-05 13:00 ` Vitaly Kuznetsov
2015-01-07 9:10 ` Olaf Hering
2015-01-07 10:41 ` David Vrabel
2015-01-07 10:54 ` Jan Beulich
2015-01-07 11:59 ` Vitaly Kuznetsov
2015-01-07 11:01 ` Olaf Hering
2015-01-13 12:18 ` Ian Campbell
2015-01-07 10:49 ` Vitaly Kuznetsov
2015-01-07 11:03 ` Olaf Hering
2015-01-14 11:06 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421157510.19103.64.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=drjones@redhat.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=keir@xen.org \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vkuznets@redhat.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.