From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libxl: provide xenlight.pc
Date: Tue, 13 Jan 2015 14:25:38 +0000
Message-ID: <1421159138.19103.84.camel@citrix.com>
References: <1420813938-23836-1-git-send-email-wei.liu2@citrix.com>
	<1421151089.19103.43.camel@citrix.com>
	<20150113121905.GA29190@aepfle.de>
	<20150113125628.GK4226@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150113125628.GK4226@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>, Ian Jackson <ian.jackson@eu.citrix.com>, jfehlig@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-01-13 at 12:56 +0000, Wei Liu wrote:
> On Tue, Jan 13, 2015 at 01:19:05PM +0100, Olaf Hering wrote:
> > On Tue, Jan 13, Ian Campbell wrote:
> > 
> > > On Fri, 2015-01-09 at 14:32 +0000, Wei Liu wrote:
> > > > A pkg-config file for libxl. It also contains two variables
> > > > (xenfirmwaredir and libexec_bin) so that tools that are very keen on
> > > > knowing the locations of Xen binaries (say, libvirt) can use them to
> > > > determine the location of the binaries.
> > > > 
> > > > Please rerun autogen.sh after applying this patch.
> > 
> > Forgot to reply to this earlier:
> > 
> > Should there really be another file.in.in.in.in mess? I think the
> > major/minor values could be placed into some m4 file so that they can be
> > substituted properly by configure.
> > 
> 
> I was two minded when I wrote this path. On one hand I didn't want to
> place a m4 file here, on the other I didn't want to leak library version
> numbers to top level m4 directory. Finally I decided to do the .in.in
> trick.
> 
> So if you have an argument for either of these please convince me...
> Or you have other idea about file placement please tell me.

I think the library SONAME belongs in the relevant Makefile, not hidden
in the m4 somewhere. Which I think necessitates .in.in. I think we can
live with that.

Ian.