From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest
	lifecycle.
Date: Tue, 13 Jan 2015 16:16:04 +0000
Message-ID: <1421165764.19103.139.camel@citrix.com>
References: <1417536141.29004.6.camel@citrix.com>
	<1417536299-1810-8-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1417536299-1810-8-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: ian.jackson@eu.citrix.com
Cc: Jim Fehlig <jfehlig@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-12-02 at 16:04 +0000, Ian Campbell wrote:
> +sub create ($$) {
> +    my ($self,$cfg) = @_;
> +    my $ho = $self->{Host};
> +    my $lcfg = $cfg;
> +    $lcfg =~ s,/,-,g;
> +    $lcfg = "$ho->{Name}--$lcfg";
> +    target_cmd_root($ho, "virsh domxml-from-native xen-xm $cfg > $cfg.xml", 30);

Given that Jim is in the process of introducing support for "xen-xl" cfg
file consumption I intend to make this xen-xl unconditionally.

Testing older versions of libvirt (which don't speak xen-xl) will
therefore continue to fail at the guest-start test step, as they do
today, and hence it will not appears as a regression.

Testing newer versions of libvirt will pass as expected


Ian.