All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC] make error codes a formal part of the ABI
Date: Tue, 13 Jan 2015 17:10:04 +0000	[thread overview]
Message-ID: <1421169004.19103.167.camel@eu.citrix.com> (raw)
In-Reply-To: <21685.20084.251202.502689@mariner.uk.xensource.com>

On Tue, 2015-01-13 at 16:57 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH RFC] make error codes a formal part of the ABI"):
> > On Tue, 2015-01-13 at 16:21 +0000, Jan Beulich wrote:
> > > There's on small block commented with TBD left in the public header.
> > > This is the main reason for the submission being RFC. While we don't
> > > currently use these error codes, I'm not sure if we should leave all
> > > or some of them out for the time being.
> > 
> > I say lets omit any we don't use for now.
> 
> Is it possible that anyone is using the existing header file where
> these values were defined ?

It's not installed or in the regular header paths, so it seems unlikely,
or at least they would have had to jump through some hoops and no doubt
have a big comment about their fragile hack...

>   If so their code might say
>   case ELOOP:
> which would not compile when they switched to the new header.
> 
> I don't know whether this is likely, or a problem.
> 
> Ian.

  reply	other threads:[~2015-01-13 17:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 16:21 [PATCH RFC] make error codes a formal part of the ABI Jan Beulich
2015-01-13 16:35 ` Ian Campbell
2015-01-13 16:57   ` Ian Jackson
2015-01-13 17:10     ` Ian Campbell [this message]
2015-01-13 17:14     ` Jan Beulich
2015-01-14  8:46   ` Jan Beulich
2015-01-14 10:28     ` Ian Campbell
2015-01-14 10:52       ` Julien Grall
2015-01-14 11:24         ` Ian Campbell
2015-01-14 11:37           ` Andrew Cooper
2015-01-14 11:18       ` Jan Beulich
2015-01-14 11:27         ` Ian Campbell
2015-01-13 16:40 ` Andrew Cooper
2015-01-14  8:54   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421169004.19103.167.camel@eu.citrix.com \
    --to=ian.campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.