All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] config_cmd_default.h: wrap each definition in "ifndef"
Date: Wed, 14 Jan 2015 06:23:55 +0000	[thread overview]
Message-ID: <1421216635.2954.2.camel@synopsys.com> (raw)
In-Reply-To: <20150114131254.7103.AA925319@jp.panasonic.com>

Hi Masahiro-san,

On Wed, 2015-01-14 at 13:12 +0900, Masahiro Yamada wrote:
> On Fri, 9 Jan 2015 21:21:20 +0000
> Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote:
> I think this change is harmless, but
> 
> #define CONFIG_CMD_BDI   1
> 
> is simpler than
> 
> #ifndef CONFIG_CMD_BDI
> #define CONFIG_CMD_BDI
> #endif
> 
> 
> Maybe?

I don't think so :)

Please look at Wolfgang's comment here
http://lists.denx.de/pipermail/u-boot/2014-February/172494.html

--->8---
Please do not define values for logical variables [please check
everywhere].
--->8---

-Alexey

  reply	other threads:[~2015-01-14  6:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-03 13:20 [U-Boot] [PATCH 0/2] select default commands in Kconfig Alexey Brodkin
2015-01-03 13:20 ` [U-Boot] [PATCH 1/2] common: mark commands as default to match "config_cmd_default.h" Alexey Brodkin
2015-01-05 15:34   ` Masahiro YAMADA
2015-01-09 20:09     ` Alexey Brodkin
2015-01-14  4:05       ` Masahiro Yamada
2015-01-14  4:18         ` Simon Glass
2015-01-14  8:18           ` Alexey Brodkin
2015-01-15 14:46             ` Simon Glass
2015-01-15 19:10               ` Masahiro YAMADA
2015-01-15 19:44                 ` Simon Glass
2015-01-15 21:49                   ` Alexey Brodkin
2015-01-16 16:55                     ` Simon Glass
2015-01-19 12:52                     ` Masahiro Yamada
2015-01-19 12:22                   ` Masahiro Yamada
2015-01-20  4:52                   ` Masahiro Yamada
2015-01-22 15:30                     ` Simon Glass
2015-01-15 18:36             ` Masahiro YAMADA
2015-01-15 21:22               ` Alexey Brodkin
2015-01-19 12:34                 ` Masahiro Yamada
2015-01-03 13:20 ` [U-Boot] [PATCH 2/2] config_cmd_default.h: wrap each definition in "ifndef" Alexey Brodkin
2015-01-09 21:21   ` Alexey Brodkin
2015-01-14  4:12     ` Masahiro Yamada
2015-01-14  6:23       ` Alexey Brodkin [this message]
2015-01-14  6:42         ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421216635.2954.2.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.