From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/configure: Check if pixman is present on the system Date: Wed, 14 Jan 2015 12:31:10 +0000 Message-ID: <1421238670.19103.253.camel@citrix.com> References: <1421172890-29763-1-git-send-email-julien.grall@linaro.org> <54B6168602000078000C581A@mail.emea.novell.com> <54B65D52.8020007@linaro.org> <1421238258.19103.247.camel@citrix.com> <54B660FB.60909@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54B660FB.60909@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-01-14 at 12:28 +0000, Julien Grall wrote: > On 14/01/15 12:24, Ian Campbell wrote: > > On Wed, 2015-01-14 at 12:13 +0000, Julien Grall wrote: > >> Hi Jan, > >> > >> On 14/01/15 07:11, Jan Beulich wrote: > >>>>>> Julien Grall 01/13/15 7:17 PM >>> > >>>> QEMU upstream requires the use of pixman. When pixman is not present the > >>>> system, the configure of QEMU will fail with: > >>>> > >>>> ERROR: pixman not present. Your options: > >>>> (1) Preferred: Install the pixman devel package (any recent > >>>> distro should have packages as Xorg needs pixman too). > >>>> (2) Fetch the pixman submodule, using: > >>>> git submodule update --init pixman > >>>> > >>>> I think we can use by default the version on the system. So check it > >>>> a Xen configuration time to avoid a build issue later. > >>> > >>> Since qemu building isn't a required part of building the tools, is a check in > >>> the tools configure process really an appropriate thing to do? > >> > >> QEMU is a required part of building the tools. > > > > Not stricty true. Pass --with-system-qemu if you wish to avoid it. > > Right. So the check for glib in the configure for ARM is not necessary > when --with-system-qemu is used. > > Might be interesting to avoid checking dependency that is not useful. I didn't think it was worth it, but given the objections perhaps putting all the checks which are there solely for qemu-upstream under a conditional based on --with-system-qemu is the way to go. Ian.