From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: nick <xerofoify@gmail.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
ashley@ashleylai.com
Subject: Re: [tpmdd-devel] Question about duplicate definitions of transmit_cmd in tpm-sysfs.c and tmp-interface.c
Date: Wed, 14 Jan 2015 18:30:36 +0200 [thread overview]
Message-ID: <1421253036.23184.4.camel@linux.intel.com> (raw)
In-Reply-To: <54A63F2D.4020803@gmail.com>
On Fri, 2015-01-02 at 01:48 -0500, nick wrote:
> Jason,
> Just a little nitpick but Jarkoo seems to have missed removing the function
> prototype, tpm_transmit as nothing uses this function anymore.
tpm-dev.c does.
> Regards Nick
/Jarkko
>
> On 2015-01-02 01:36 AM, Jason Gunthorpe wrote:
> > On Sat, Dec 27, 2014 at 01:34:51AM -0500, nick wrote:
> >
> >> After reading the code and trying various ways to merge these
> >> functions into tpm.h. I am wondering if the merge is really a good
> >> idea as it seems to break a lot of code that is very hard to trace
> >> and redo correctly without a lot of work. Further more I am curious
> >> as to why the merge is even useful as it seems unneeded to me other
> >> then to unify the function definitions which seems a minor detail to
> >> me.
> >
> > Jarkko has already sent a patch to merge them, I think you can see the
> > to be merged patch here:
> >
> > https://github.com/PeterHuewe/linux-tpmdd/commit/6e01df24a659c5f21d6beabf9b7a20a85f470cf4
> >
> > If you see a problem with it please remark..
> >
> > Jason
> >
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming! The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net
> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
prev parent reply other threads:[~2015-01-14 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <549E530B.7040301@gmail.com>
2015-01-02 6:36 ` [tpmdd-devel] Question about duplicate definitions of transmit_cmd in tpm-sysfs.c and tmp-interface.c Jason Gunthorpe
[not found] ` <54A63F2D.4020803@gmail.com>
2015-01-14 16:30 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421253036.23184.4.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ashley@ashleylai.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.